Subject: [for-next][PATCH 05/23] neighbor: tracing: Have neigh_create event use __string()

From: Steven Rostedt <[email-masked]>
Date: Thu, 14 Jul 2022 12:43:01 -0400

From: "Steven Rostedt (Google)" <[email-masked]>

The dev field of the neigh_create event uses __dynamic_array() with a
fixed size, which defeats the purpose of __dynamic_array(). Looking at the
logic, as it already uses __assign_str(), just use the same logic in
__string to create the size needed. It appears that because "dev" can be
NULL, it needs the check. But __string() can have the same checks as
__assign_str() so use them there too.

Link: https://lkml.kernel.org/r/[email-masked]

Cc: David Ahern <[email-masked]>
Cc: David S. Miller <[email-masked]>
Cc: [email-masked]
Acked-by: Jakub Kicinski <[email-masked]>
Reviewed-by: David Ahern <[email-masked]>
Signed-off-by: Steven Rostedt (Google) <[email-masked]>
---
 include/trace/events/neigh.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/neigh.h b/include/trace/events/neigh.h
index 62bb17516713..5eaa1fa99171 100644
--- a/include/trace/events/neigh.h
+++ b/include/trace/events/neigh.h
@@ -30,7 +30,7 @@ TRACE_EVENT(neigh_create,
 
 	TP_STRUCT__entry(
 		__field(u32, family)
-		__dynamic_array(char,  dev,   IFNAMSIZ )
+		__string(dev, dev ? dev->name : "NULL")
 		__field(int, entries)
 		__field(u8, created)
 		__field(u8, gc_exempt)
-- 
2.35.1