Subject: Re: [PATCH net-next 2/9] net: devlink: remove region snapshots list dependency on devlink->lock

From: Jakub Kicinski <[email-masked]>
Date: Wed, 27 Jul 2022 19:01:56 -0700

On Wed, 27 Jul 2022 20:03:29 +0300 Moshe Shemesh wrote:
> From: Jiri Pirko <[email-masked]>
> 
> After mlx4 driver is converted to do locked reload,
> devlink_region_snapshot_create() may be called from both locked and
> unlocked context.

You need to explain why, tho. What makes region snapshots special? 

> So resolve this by removing dependency on devlink->lock for region
> snapshots list consistency and introduce new mutex to ensure it.

I was hoping to avoid per-subobject locks. What prevents us from
depending on the instance lock here (once the driver is converted)?