From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
mkubecek@suse•cz, johannes@sipsolutions•net,
Jakub Kicinski <kuba@kernel•org>
Subject: [PATCH net-next 0/6] netlink: support reporting missing attributes
Date: Tue, 23 Aug 2022 21:50:18 -0700 [thread overview]
Message-ID: <20220824045024.1107161-1-kuba@kernel.org> (raw)
This series adds support for reporting missing attributes
in a structured way. We can't point at things which don't
exist so we point at the containing nest or preceding
fixed header and report which attr type we expected to see.
Example of (YAML-based) user space reporting ethtool header
missing:
Kernel error: missing attribute: .header
I was tempted to integrate the check with the policy
but it seems tricky without doing a full scan, and there
may be a ton of attrs in the policy. So leaving that
for later.
Jakub Kicinski (6):
netlink: add support for ext_ack missing attributes
netlink: add helper for extack attr presence checking
genetlink: add helper for checking required attrs and use it in
devlink
devlink: use missing attribute ext_ack
ethtool: strset: report missing ETHTOOL_A_STRINGSET_ID via ext_ack
ethtool: report missing header via ext_ack in the default handler
Documentation/userspace-api/netlink/intro.rst | 7 +++-
include/linux/netlink.h | 24 +++++++++++
include/net/genetlink.h | 14 +++++++
include/uapi/linux/netlink.h | 4 ++
net/core/devlink.c | 41 +++++++++----------
net/ethtool/netlink.c | 3 ++
net/ethtool/strset.c | 2 +-
net/netlink/af_netlink.c | 12 ++++++
net/netlink/genetlink.c | 2 +-
9 files changed, 84 insertions(+), 25 deletions(-)
--
2.37.2
next reply other threads:[~2022-08-24 4:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 4:50 Jakub Kicinski [this message]
2022-08-24 4:50 ` [PATCH net-next 1/6] netlink: add support for ext_ack missing attributes Jakub Kicinski
2022-08-24 8:09 ` Johannes Berg
2022-08-24 8:13 ` Johannes Berg
2022-08-24 16:36 ` Jakub Kicinski
2022-08-24 4:50 ` [PATCH net-next 2/6] netlink: add helper for extack attr presence checking Jakub Kicinski
2022-08-24 4:50 ` [PATCH net-next 3/6] genetlink: add helper for checking required attrs and use it in devlink Jakub Kicinski
2022-08-24 19:44 ` Johannes Berg
2022-08-24 22:46 ` Jakub Kicinski
2022-08-24 4:50 ` [PATCH net-next 4/6] devlink: use missing attribute ext_ack Jakub Kicinski
2022-08-24 4:50 ` [PATCH net-next 5/6] ethtool: strset: report missing ETHTOOL_A_STRINGSET_ID via ext_ack Jakub Kicinski
2022-08-24 4:50 ` [PATCH net-next 6/6] ethtool: report missing header via ext_ack in the default handler Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220824045024.1107161-1-kuba@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox