Subject: Re: [PATCH net-next v2 6/7] ethtool: add interface to interact with Ethernet Power Equipment

From: Jakub Kicinski <[email-masked]>
Date: Thu, 25 Aug 2022 11:10:19 -0700

On Thu, 25 Aug 2022 15:02:10 +0200 Oleksij Rempel wrote:
> +enum ethtool_podl_pse_admin_state {
> +	ETHTOOL_PODL_PSE_ADMIN_STATE_UNKNOWN = 1,

Why define UNKNOWN.. as 1? No real objection here, just in my head
somehow UNKNOWN = 0 or just start from 1.

> +	ETHTOOL_PODL_PSE_ADMIN_STATE_DISABLED,
> +	ETHTOOL_PODL_PSE_ADMIN_STATE_ENABLED,
> +
> +	/* add new constants above here */
> +	ETHTOOL_PODL_PSE_ADMIN_STATE_COUNT

Why define count for a value enum like this? For attrs we define it
because it's used to size tables, don't think anyone will size tables
based on states.

There's a bunch of kdoc warnings in the patches as well.