From: Kees Cook <keescook@chromium•org>
To: "Gustavo A. R. Silva" <gustavoars@kernel•org>
Cc: Vincent Mailhol <mailhol.vincent@wanadoo•fr>,
Wolfgang Grandegger <wg@grandegger•com>,
Marc Kleine-Budde <mkl@pengutronix•de>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
linux-can@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-hardening@vger•kernel.org
Subject: Re: [PATCH][next] can: etas_es58x: Replace zero-length array with DECLARE_FLEX_ARRAY() helper
Date: Mon, 29 Aug 2022 15:06:49 -0700 [thread overview]
Message-ID: <202208291506.869166F4CE@keescook> (raw)
In-Reply-To: <Yw00w6XRcq7B6ub6@work>
On Mon, Aug 29, 2022 at 04:50:59PM -0500, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated and we are moving towards adopting
> C99 flexible-array members, instead. So, replace zero-length array
> declaration in union es58x_urb_cmd with the new DECLARE_FLEX_ARRAY()
> helper macro.
>
> This helper allows for a flexible-array member in a union.
>
> Link: https://github.com/KSPP/linux/issues/193
> Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel•org>
Reviewed-by: Kees Cook <keescook@chromium•org>
--
Kees Cook
next prev parent reply other threads:[~2022-08-29 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 21:50 [PATCH][next] can: etas_es58x: Replace zero-length array with DECLARE_FLEX_ARRAY() helper Gustavo A. R. Silva
2022-08-29 22:06 ` Kees Cook [this message]
2022-08-30 1:15 ` Vincent MAILHOL
2022-09-06 6:29 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202208291506.869166F4CE@keescook \
--to=keescook@chromium$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-can@vger$(echo .)kernel.org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mailhol.vincent@wanadoo$(echo .)fr \
--cc=mkl@pengutronix$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=wg@grandegger$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox