From: Jakub Kicinski <kuba@kernel•org>
To: menglong8.dong@gmail•com
Cc: edumazet@google•com, davem@davemloft•net, pabeni@redhat•com,
rostedt@goodmis•org, mingo@redhat•com, imagedong@tencent•com,
dsahern@kernel•org, flyingpeng@tencent•com,
dongli.zhang@oracle•com, robh@kernel•org, asml.silence@gmail•com,
luiz.von.dentz@intel•com, vasily.averin@linux•dev,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] net: skb: export skb drop reaons to user by TRACE_DEFINE_ENUM
Date: Thu, 1 Sep 2022 14:12:57 -0700 [thread overview]
Message-ID: <20220901141257.07131439@kernel.org> (raw)
In-Reply-To: <20220901152339.471045-1-imagedong@tencent.com>
On Thu, 1 Sep 2022 23:23:39 +0800 menglong8.dong@gmail•com wrote:
> +#undef FN
> +#define FN(reason) [SKB_DROP_REASON_##reason] = #reason,
> +const char * const drop_reasons[] = {
> + DEFINE_DROP_REASON(FN, FN)
> +};
The undef looks a little backwards, no? We don't want to pollute all
users of skbuff.h with a FN define.
#define FN....
/* use it */
#undef FN
next prev parent reply other threads:[~2022-09-01 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 15:23 [PATCH net-next] net: skb: export skb drop reaons to user by TRACE_DEFINE_ENUM menglong8.dong
2022-09-01 21:12 ` Jakub Kicinski [this message]
2022-09-02 2:13 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901141257.07131439@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=asml.silence@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dongli.zhang@oracle$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=flyingpeng@tencent$(echo .)com \
--cc=imagedong@tencent$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=luiz.von.dentz@intel$(echo .)com \
--cc=menglong8.dong@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=vasily.averin@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox