From: Stephen Hemminger <stephen@networkplumber•org>
To: Daniel Machon <daniel.machon@microchip•com>
Cc: <netdev@vger•kernel.org>, <Allan.Nielsen@microchip•com>,
<UNGLinuxDriver@microchip•com>, <maxime.chevallier@bootlin•com>,
<vladimir.oltean@nxp•com>, <petrm@nvidia•com>, <kuba@kernel•org>,
<vinicius.gomes@intel•com>, <thomas.petazzoni@bootlin•com>
Subject: Re: [RFC PATCH iproute2-next 2/2] dcb: add new subcommand for apptrust object
Date: Fri, 9 Sep 2022 08:06:31 -0700 [thread overview]
Message-ID: <20220909080631.6941a770@hermes.local> (raw)
In-Reply-To: <20220909103701.468717-3-daniel.machon@microchip.com>
On Fri, 9 Sep 2022 12:37:01 +0200
Daniel Machon <daniel.machon@microchip•com> wrote:
> } else if (matches(*argv, "app") == 0) {
> return dcb_cmd_app(dcb, argc - 1, argv + 1);
> + } else if (matches(*argv, "apptrust") == 0) {
> + return dcb_cmd_apptrust(dcb, argc - 1, argv + 1);
> } else if (matches(*argv, "buffer") == 0) {
Yet another example of why matches() is bad.
Perhaps this should be named trust instead of apptrust.
next prev parent reply other threads:[~2022-09-09 15:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 10:36 [RFC PATCH iproute2-next 0/2] Add pcp-prio and new APPTRUST subcommand Daniel Machon
2022-09-09 10:37 ` [RFC PATCH iproute2-next 1/2] dcb: add new pcp-prio parameter to dcb app Daniel Machon
2022-09-09 10:37 ` [RFC PATCH iproute2-next 2/2] dcb: add new subcommand for apptrust object Daniel Machon
2022-09-09 15:06 ` Stephen Hemminger [this message]
2022-09-12 6:09 ` Daniel.Machon
2022-09-12 16:34 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220909080631.6941a770@hermes.local \
--to=stephen@networkplumber$(echo .)org \
--cc=Allan.Nielsen@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=daniel.machon@microchip$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=petrm@nvidia$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vinicius.gomes@intel$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox