Subject: Re: [PATCH v2] net: ethernet: altera: TSE: fix error return code in altera_tse_probe()

From: Jakub Kicinski <[email-masked]>
Date: Mon, 19 Sep 2022 14:09:51 -0700

On Fri, 9 Sep 2022 10:46:17 +0800 Sun Ke wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: fef2998203e1 ("net: altera: tse: convert to phylink")
> Reported-by: kernel test robot <[email-masked]>
> Signed-off-by: Sun Ke <[email-masked]>

You must CC Maxime, who authored the change under Fixes,
and is most likely the best person to give us a review.
Please repost with the CC fixed.

> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index 89ae6d1623aa..3cf409bdb283 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -1411,6 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev)
>  				       priv->phy_iface, &alt_tse_phylink_ops);
>  	if (IS_ERR(priv->phylink)) {
>  		dev_err(&pdev->dev, "failed to create phylink\n");
> +		ret = PTR_ERR(priv->phylink);
>  		goto err_init_phy;
>  	}
>