Subject: Re: [PATCH net v2] bnxt_en: replace reset with config timestamps

From: Jakub Kicinski <[email-masked]>
Date: Wed, 21 Sep 2022 17:38:18 -0700

On Thu, 22 Sep 2022 01:44:30 +0300 Vadim Fedorenko wrote:
> +		if (ptp->rx_filter == PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_ENABLE) {

Doesn't ptp->rx_filter hold the uAPI values, i.e. HWTSTAMP_FILTER_* ?

> +			rc = bnxt_close_nic(bp, false, false);
> +			if (!rc)
> +				rc = bnxt_open_nic(bp, false, false);
> +		} else
> +			bnxt_ptp_cfg_tstamp_filters(bp);

nit: missing brackets around the else branch