From: Kees Cook <keescook@chromium•org>
To: Feng Tang <feng.tang@intel•com>, Vlastimil Babka <vbabka@suse•cz>
Cc: Hyeonggon Yoo <42.hyeyoo@gmail•com>,
Pekka Enberg <penberg@kernel•org>,
David Rientjes <rientjes@google•com>,
Joonsoo Kim <iamjoonsoo.kim@lge•com>,
Andrew Morton <akpm@linux-foundation•org>,
"linux-mm@kvack•org" <linux-mm@kvack•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Nick Desaulniers <ndesaulniers@google•com>,
Alex Elder <elder@kernel•org>, Josef Bacik <josef@toxicpanda•com>,
David Sterba <dsterba@suse•com>,
Sumit Semwal <sumit.semwal@linaro•org>,
Christian K??nig <christian.koenig@amd•com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel•com>,
Daniel Micay <danielmicay@gmail•com>, Yonghong Song <yhs@fb•com>,
Marco Elver <elver@google•com>, Miguel Ojeda <ojeda@kernel•org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-btrfs@vger•kernel.org" <linux-btrfs@vger•kernel.org>,
"linux-media@vger•kernel.org" <linux-media@vger•kernel.org>,
"dri-devel@lists•freedesktop.org"
<dri-devel@lists•freedesktop.org>,
"linaro-mm-sig@lists•linaro.org" <linaro-mm-sig@lists•linaro.org>,
"linux-fsdevel@vger•kernel.org" <linux-fsdevel@vger•kernel.org>,
"intel-wired-lan@lists•osuosl.org"
<intel-wired-lan@lists•osuosl.org>,
"dev@openvswitch•org" <dev@openvswitch•org>,
"x86@kernel•org" <x86@kernel•org>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"llvm@lists•linux.dev" <llvm@lists•linux.dev>,
"linux-hardening@vger•kernel.org"
<linux-hardening@vger•kernel.org>
Subject: Re: [PATCH 01/12] slab: Introduce kmalloc_size_roundup()
Date: Fri, 23 Sep 2022 11:50:37 -0700 [thread overview]
Message-ID: <202209231145.7654767ED5@keescook> (raw)
In-Reply-To: <Yy0JJV4c3DffCF+4@feng-clx>
On Fri, Sep 23, 2022 at 09:17:25AM +0800, Feng Tang wrote:
> On Thu, Sep 22, 2022 at 07:12:21PM +0800, Hyeonggon Yoo wrote:
> > On Wed, Sep 21, 2022 at 08:10:02PM -0700, Kees Cook wrote:
> > > [...]
> > > Introduce kmalloc_size_roundup(), to serve this function so we can start
> > > replacing the "anticipatory resizing" uses of ksize().
> > [...]
> >
> > This looks okay.
> > [...]
> > Cc-ing Feng Tang who may welcome this series ;)
>
> Indeed! This will help our work of extending slub redzone check,
> as we also ran into some trouble with ksize() users when extending
> the redzone support to this extra allocated space than requested
> size [1], and have to disable the redzone sanity for all ksize()
> users [2].
>
> [1]. https://lore.kernel.org/lkml/20220719134503.GA56558@shbuild999.sh.intel.com/
> [2]. https://lore.kernel.org/lkml/20220913065423.520159-5-feng.tang@intel.com/
Thanks for the feedback! I'll send my v2 series -- I'm hoping at least
this patch can land in v6.1 so the various other patches would be clear
to land via their separate trees, etc.
--
Kees Cook
next prev parent reply other threads:[~2022-09-23 18:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 3:10 [PATCH 00/12] slab: Introduce kmalloc_size_roundup() Kees Cook
2022-09-22 3:10 ` [PATCH 01/12] " Kees Cook
2022-09-22 11:12 ` Hyeonggon Yoo
2022-09-23 1:17 ` Feng Tang
2022-09-23 18:50 ` Kees Cook [this message]
2022-09-22 3:10 ` [PATCH 02/12] skbuff: Proactively round up to kmalloc bucket size Kees Cook
2022-09-22 19:40 ` Jakub Kicinski
2022-09-22 3:10 ` [PATCH 03/12] net: ipa: " Kees Cook
2022-09-22 13:45 ` Alex Elder
2022-09-22 15:57 ` Kees Cook
2022-09-22 3:10 ` [PATCH 04/12] btrfs: send: " Kees Cook
2022-09-22 13:30 ` David Sterba
2022-09-22 3:10 ` [PATCH 05/12] dma-buf: " Kees Cook
2022-09-22 3:10 ` [PATCH 06/12] coredump: " Kees Cook
2022-09-22 3:10 ` [PATCH 07/12] igb: " Kees Cook
2022-09-22 15:56 ` Ruhl, Michael J
2022-09-22 16:00 ` Kees Cook
2022-09-22 3:10 ` [PATCH 08/12] openvswitch: " Kees Cook
2022-09-22 3:10 ` [PATCH 09/12] x86/microcode/AMD: Track patch allocation size explicitly Kees Cook
2022-09-22 3:10 ` [PATCH 10/12] iwlwifi: Track scan_cmd " Kees Cook
2022-09-22 4:18 ` Kalle Valo
2022-09-22 5:26 ` Kees Cook
2022-09-22 3:10 ` [PATCH 11/12] slab: Remove __malloc attribute from realloc functions Kees Cook
2022-09-22 9:23 ` Miguel Ojeda
2022-09-22 15:56 ` Kees Cook
2022-09-22 17:41 ` Miguel Ojeda
2022-09-22 3:10 ` [PATCH 12/12] slab: Restore __alloc_size attribute to __kmalloc_track_caller Kees Cook
2022-09-22 7:10 ` [PATCH 00/12] slab: Introduce kmalloc_size_roundup() Christian König
2022-09-22 15:55 ` Kees Cook
2022-09-22 21:05 ` Vlastimil Babka
2022-09-22 21:49 ` Kees Cook
2022-09-23 9:07 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209231145.7654767ED5@keescook \
--to=keescook@chromium$(echo .)org \
--cc=42.hyeyoo@gmail$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=christian.koenig@amd$(echo .)com \
--cc=danielmicay@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dev@openvswitch$(echo .)org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=dsterba@suse$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=elder@kernel$(echo .)org \
--cc=elver@google$(echo .)com \
--cc=feng.tang@intel$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=iamjoonsoo.kim@lge$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=josef@toxicpanda$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linaro-mm-sig@lists$(echo .)linaro.org \
--cc=linux-btrfs@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=ndesaulniers@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ojeda@kernel$(echo .)org \
--cc=pabeni@redhat$(echo .)com \
--cc=penberg@kernel$(echo .)org \
--cc=rientjes@google$(echo .)com \
--cc=sumit.semwal@linaro$(echo .)org \
--cc=vbabka@suse$(echo .)cz \
--cc=x86@kernel$(echo .)org \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox