Subject: Re: [PATCH net-next 2/3] nfp: add support for link auto negotiation

From: Jakub Kicinski <[email-masked]>
Date: Mon, 26 Sep 2022 09:25:47 -0700

On Sat, 24 Sep 2022 10:45:30 +0800 Yinjun Zhang wrote:
> On Fri, Sep 23, 2022 at 05:24:10PM -0700, Jakub Kicinski wrote:
> > > Because the value of sp_indiff depends on the loaded application
> > > firmware, please ref to previous commit:
> > > 2b88354d37ca ("nfp: check if application firmware is indifferent to port speed")  
> > 
> > AFAICT you check if it's flower, you can check that in the main code,
> > the app id is just a symbol, right?  
> 
> Not only check if it's flower, but also check if it's sp_indiff when
> it's not flower by parsing the tlv caps.

Seems bogus. The speed independence is a property of the whole FW image,
you record it in the pf structure.