From: Jakub Kicinski <kuba@kernel•org>
To: Hangbin Liu <liuhangbin@gmail•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Ido Schimmel <idosch@nvidia•com>,
Petr Machata <petrm@nvidia•com>,
Florent Fourcot <florent.fourcot@wifirst•fr>,
Nikolay Aleksandrov <razor@blackwall•org>,
Nicolas Dichtel <nicolas.dichtel@6wind•com>,
Guillaume Nault <gnault@redhat•com>,
David Ahern <dsahern@kernel•org>
Subject: Re: [PATCHv3 net-next] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, set, del}link
Date: Tue, 27 Sep 2022 07:21:30 -0700 [thread overview]
Message-ID: <20220927072130.6d5204a3@kernel.org> (raw)
In-Reply-To: <20220927041303.152877-1-liuhangbin@gmail.com>
On Tue, 27 Sep 2022 12:13:03 +0800 Hangbin Liu wrote:
> @@ -3382,6 +3401,12 @@ static int rtnl_newlink_create(struct sk_buff *skb, struct ifinfomsg *ifm,
> if (err)
> goto out_unregister;
> }
> +
> + nskb = rtmsg_ifinfo_build_skb(RTM_NEWLINK, dev, 0, 0, GFP_KERNEL, NULL,
> + 0, pid, nlh->nlmsg_seq);
> + if (nskb)
> + rtnl_notify(nskb, dev_net(dev), pid, RTNLGRP_LINK, nlh, GFP_KERNEL);
> +
> out:
> if (link_net)
> put_net(link_net);
I'm surprised you're adding new notifications. Does the kernel not
already notify about new links? I thought rtnl_newlink_create() ->
rtnl_configure_link() -> __dev_notify_flags() sends a notification,
already.
next prev parent reply other threads:[~2022-09-27 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 4:13 [PATCHv3 net-next] rtnetlink: Honour NLM_F_ECHO flag in rtnl_{new, set, del}link Hangbin Liu
2022-09-27 14:21 ` Jakub Kicinski [this message]
2022-09-28 2:39 ` Hangbin Liu
2022-09-28 9:47 ` Guillaume Nault
2022-09-29 3:10 ` Hangbin Liu
2022-09-29 13:40 ` Jakub Kicinski
2022-09-29 14:32 ` Guillaume Nault
2022-09-28 3:22 ` Hangbin Liu
2022-09-28 9:55 ` Guillaume Nault
2022-09-28 14:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220927072130.6d5204a3@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=florent.fourcot@wifirst$(echo .)fr \
--cc=gnault@redhat$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=razor@blackwall$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox