Subject: Re: [PATCH net-next 0/2] Add helper functions to parse netlink msg of ip_tunnel

From: Jakub Kicinski <[email-masked]>
Date: Tue, 27 Sep 2022 07:58:55 -0700

On Mon, 26 Sep 2022 21:19:42 +0800 Liu Jian wrote:
> Add helper functions to parse netlinkmsg of ip_tunnel
> 
> Liu Jian (2):
>   net: Add helper function to parse netlink msg of ip_tunnel_encap
>   net: Add helper function to parse netlink msg of ip_tunnel_parm
> 
>  include/net/ip_tunnels.h | 66 ++++++++++++++++++++++++++++++++++++++++
>  net/ipv4/ipip.c          | 62 ++-----------------------------------
>  net/ipv6/ip6_tunnel.c    | 37 ++--------------------
>  net/ipv6/sit.c           | 65 ++-------------------------------------

Do they need to be in a header file? Could you put them in
net/ipv4/ip_tunnel.c or net/ipv4/ip_tunnel_core.c instead?