Subject: Re: [PATCH net-next 08/12] macsec: use NLA_POLICY_VALIDATE_FN to validate IFLA_MACSEC_CIPHER_SUITE

From: Jakub Kicinski <[email-masked]>
Date: Thu, 29 Sep 2022 09:08:40 -0700

On Wed, 28 Sep 2022 18:17:21 +0200 Sabrina Dubroca wrote:
> Unfortunately, since the value of MACSEC_DEFAULT_CIPHER_ID doesn't fit
> near the others, we can't use a simple range in the policy.

This one warns: 

drivers/net/macsec.c:4122:6: warning: variable 'csid' set but not used [-Wunused-but-set-variable]
        u64 csid = MACSEC_DEFAULT_CIPHER_ID;
            ^