Subject: Re: [PATCH v4] net: mv643xx_eth: support MII/GMII/RGMII modes for Kirkwood

From: Jakub Kicinski <[email-masked]>
Date: Fri, 30 Sep 2022 17:59:42 -0700

On Sat,  1 Oct 2022 06:25:39 +0800 David Yang wrote:
> Support mode switch properly, which is not available before.
> 
> If SoC has two Ethernet controllers, by setting both of them into MII
> mode, the first controller enters GMII mode, while the second
> controller is effectively disabled. This requires configuring (and
> maybe enabling) the second controller in the device tree, even though
> it cannot be used.

Well, this version does not build:

drivers/net/ethernet/marvell/mv643xx_eth.c:1252:38: error: member reference type 'struct device' is not a pointer; did you mean to use '.'?
            of_device_is_compatible(dev->dev->of_node,
                                    ~~~~~~~~^~
                                            .