From: Oleksij Rempel <o.rempel@pengutronix•de>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com, kernel test robot <lkp@intel•com>,
linux@rempel-privat•de, andrew@lunn•ch, bagasdotme@gmail•com
Subject: Re: [PATCH net-next] eth: pse: add missing static inlines
Date: Tue, 4 Oct 2022 06:51:08 +0200 [thread overview]
Message-ID: <20221004045108.GA14757@pengutronix.de> (raw)
In-Reply-To: <20221004040327.2034878-1-kuba@kernel.org>
On Mon, Oct 03, 2022 at 09:03:27PM -0700, Jakub Kicinski wrote:
> build bot reports missing 'static inline' qualifiers in the header.
>
> Reported-by: kernel test robot <lkp@intel•com>
> Fixes: 18ff0bcda6d1 ("ethtool: add interface to interact with Ethernet Power Equipment")
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix•de>
Thank you!
> ---
> CC: linux@rempel-privat•de
> CC: andrew@lunn•ch
> CC: bagasdotme@gmail•com
> CC: lkp@intel•com
> ---
> include/linux/pse-pd/pse.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/pse-pd/pse.h b/include/linux/pse-pd/pse.h
> index fd1a916eeeba..fb724c65c77b 100644
> --- a/include/linux/pse-pd/pse.h
> +++ b/include/linux/pse-pd/pse.h
> @@ -110,16 +110,16 @@ static inline void pse_control_put(struct pse_control *psec)
> {
> }
>
> -int pse_ethtool_get_status(struct pse_control *psec,
> - struct netlink_ext_ack *extack,
> - struct pse_control_status *status)
> +static inline int pse_ethtool_get_status(struct pse_control *psec,
> + struct netlink_ext_ack *extack,
> + struct pse_control_status *status)
> {
> return -ENOTSUPP;
> }
>
> -int pse_ethtool_set_config(struct pse_control *psec,
> - struct netlink_ext_ack *extack,
> - const struct pse_control_config *config)
> +static inline int pse_ethtool_set_config(struct pse_control *psec,
> + struct netlink_ext_ack *extack,
> + const struct pse_control_config *config)
> {
> return -ENOTSUPP;
> }
> --
> 2.37.3
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-10-04 4:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 4:03 [PATCH net-next] eth: pse: add missing static inlines Jakub Kicinski
2022-10-04 4:51 ` Oleksij Rempel [this message]
2022-10-04 5:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004045108.GA14757@pengutronix.de \
--to=o.rempel@pengutronix$(echo .)de \
--cc=andrew@lunn$(echo .)ch \
--cc=bagasdotme@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux@rempel-privat$(echo .)de \
--cc=lkp@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox