Subject: Re: [PATCH] net: benet: use snprintf instead sprintf and IFNAMSIZ instead hardcoded constant.

From: Jakub Kicinski <[email-masked]>
Date: Tue, 4 Oct 2022 17:30:46 -0700

On Tue, 4 Oct 2022 08:29:36 -0700 Stephen Hemminger wrote:
> On Tue,  4 Oct 2022 12:50:34 +0300
> Peter Kosyh <[email-masked]> wrote:
> 
> > printf to array 'eqo->desc' of size 32 may cause buffer overflow when
> > using non-standard IFNAMSIZ.
> > 
> > Found by Linux Verification Center (linuxtesting.org) with SVACE.
> > 
> > Signed-off-by: Peter Kosyh <[email-masked]>  
> 
> NACK
> Non-standard IFNAMSIZ will break uapi and many things.
> I see no reason for kernel or tools like iproute2 to support or
> fix those related bugs.

I think the commit message is missing the point, but the warning
may be legit.

Pater please read the requirements for sending patches based on
automated checkers:

  Documentation/process/researcher-guidelines.rst