From: "Marek Behún" <kabel@kernel•org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
Cc: linux@armlinux•org.uk, andrew@lunn•ch, hkallweit1@gmail•com,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, netdev@vger•kernel.org,
linux-renesas-soc@vger•kernel.org
Subject: Re: [PATCH RFC 2/3] net: phy: marvell10g: Add host interface speed configuration
Date: Wed, 19 Oct 2022 12:55:00 +0200 [thread overview]
Message-ID: <20221019125500.271e4ba3@dellmb> (raw)
In-Reply-To: <20221019124839.33ad3458@dellmb>
On Wed, 19 Oct 2022 12:48:39 +0200
Marek Behún <kabel@kernel•org> wrote:
> On Wed, 19 Oct 2022 17:50:51 +0900
> Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com> wrote:
>
> > Add support for selecting host speed mode. For now, only support
> > 1000M bps.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
> > ---
> > drivers/net/phy/marvell10g.c | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c
> > index 383a9c9f36e5..daf3242c6078 100644
> > --- a/drivers/net/phy/marvell10g.c
> > +++ b/drivers/net/phy/marvell10g.c
> > @@ -101,6 +101,10 @@ enum {
> > MV_AN_21X0_SERDES_CTRL2_AUTO_INIT_DIS = BIT(13),
> > MV_AN_21X0_SERDES_CTRL2_RUN_INIT = BIT(15),
> >
> > + MV_MOD_CONF = 0xf000,
> > + MV_MOD_CONF_SPEED_MASK = 0x00c0,
> > + MV_MOD_CONF_SPEED_1000 = BIT(7),
> > +
>
> Where did you get these values from? My documentation says:
> Mode Configuration
> Device 31, Register 0xF000
> Bits
> 7:6 Reserved R/W 0x3 This must always be 11.
Ah, I see. Probably from the MTD API sources...
But the bits should be set to 0x3 after HW reset, which means 10 Gbps,
and this should not interfere with 1000 Mbps SGMII operation. Do you
really need to set this? Isn't setting the MACTYPE to SGMII sufficient?
Marek
next prev parent reply other threads:[~2022-10-19 12:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 8:50 [PATCH RFC 0/3] net: phy: marvell10g: Add host speed setting by an ethernet driver Yoshihiro Shimoda
2022-10-19 8:50 ` [PATCH RFC 1/3] net: mdio: Add of_phy_connect_with_host_param() Yoshihiro Shimoda
2022-10-19 8:50 ` [PATCH RFC 2/3] net: phy: marvell10g: Add host interface speed configuration Yoshihiro Shimoda
2022-10-19 10:48 ` Marek Behún
2022-10-19 10:55 ` Marek Behún [this message]
2022-10-19 11:58 ` Russell King (Oracle)
2022-10-20 1:26 ` Yoshihiro Shimoda
2022-10-20 1:15 ` Yoshihiro Shimoda
2022-10-19 8:50 ` [PATCH RFC 3/3] net: renesas: rswitch: Pass host parameters to phydev Yoshihiro Shimoda
2022-10-19 10:41 ` Marek Behún
2022-10-20 0:40 ` Yoshihiro Shimoda
2022-10-19 10:44 ` [PATCH RFC 0/3] net: phy: marvell10g: Add host speed setting by an ethernet driver Marek Behún
2022-10-19 11:39 ` Russell King (Oracle)
2022-10-20 1:20 ` Yoshihiro Shimoda
2022-10-20 1:04 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019125500.271e4ba3@dellmb \
--to=kabel@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox