From: Jakub Kicinski <kuba@kernel•org>
To: <edward.cree@amd•com>
Cc: <netdev@vger•kernel.org>, <linux-net-drivers@amd•com>,
<davem@davemloft•net>, <pabeni@redhat•com>, <edumazet@google•com>,
<habetsm.xilinx@gmail•com>, <johannes@sipsolutions•net>,
<marcelo.leitner@gmail•com>, <jiri@resnulli•us>,
Edward Cree <ecree.xilinx@gmail•com>
Subject: Re: [PATCH v3 net-next 1/3] netlink: add support for formatted extack messages
Date: Wed, 19 Oct 2022 13:05:42 -0700 [thread overview]
Message-ID: <20221019130542.3879a64c@kernel.org> (raw)
In-Reply-To: <f6cdbbf29de087257201abd06ddaff0593236106.1666102698.git.ecree.xilinx@gmail.com>
On Tue, 18 Oct 2022 15:37:27 +0100 edward.cree@amd•com wrote:
> Include an 80-byte buffer in struct netlink_ext_ack that can be used
> for scnprintf()ed messages. This does mean that the resulting string
> can't be enumerated, translated etc. in the way NL_SET_ERR_MSG() was
> designed to allow.
I only read the code not the message yesterday, but FWIW I think
the translation problem is surmountable within the format string
itself. But let's worry about that if someone actually comes forward
and wants to work on the translations :/
next prev parent reply other threads:[~2022-10-19 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 14:37 [PATCH v3 net-next 0/3] netlink: formatted extacks edward.cree
2022-10-18 14:37 ` [PATCH v3 net-next 1/3] netlink: add support for formatted extack messages edward.cree
2022-10-19 2:09 ` Jakub Kicinski
2022-10-19 20:05 ` Jakub Kicinski [this message]
2022-10-18 14:37 ` [PATCH v3 net-next 2/3] sfc: use formatted extacks instead of efx_tc_err() edward.cree
2022-10-18 14:37 ` [PATCH v3 net-next 3/3] sfc: remove 'log-tc-errors' ethtool private flag edward.cree
2022-10-19 22:10 ` [PATCH v3 net-next 0/3] netlink: formatted extacks patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221019130542.3879a64c@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=edward.cree@amd$(echo .)com \
--cc=habetsm.xilinx@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linux-net-drivers@amd$(echo .)com \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox