Subject: Re: [V3 net 09/16] net/mlx5: SF: Fix probing active SFs during driver probe phase

From: Jakub Kicinski <[email-masked]>
Date: Mon, 24 Oct 2022 21:27:28 -0700

On Mon, 24 Oct 2022 12:53:50 +0100 Saeed Mahameed wrote:
> From: Shay Drory <[email-masked]>
> 
> When SF devices and SF port representors are located on different
> functions, unloading and reloading of SF parent driver doesn't recreate
> the existing SF present in the device.
> Fix it by querying SFs and probe active SFs during driver probe phase.
> 
> Fixes: 90d010b8634b ("net/mlx5: SF, Add auxiliary device support")
> Signed-off-by: Shay Drory <[email-masked]>
> Reviewed-by: Parav Pandit <[email-masked]>
> Signed-off-by: Saeed Mahameed <[email-masked]>

Does not build cleanly, I thought v1 built :S

drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c:287:6: warning: no previous prototype for function 'mlx5_sf_dev_destroy_active_work' [-Wmissing-prototypes]
void mlx5_sf_dev_destroy_active_work(struct mlx5_sf_dev_table *table)
     ^