Subject: Re: [PATCH v7 02/23] iov_iter: DDP copy to iter/pages

From: Jakub Kicinski <[email-masked]>
Date: Tue, 25 Oct 2022 15:40:03 -0700

On Tue, 25 Oct 2022 16:59:37 +0300 Aurelien Aptel wrote:
> Signed-off-by: Ben Ben-Ishay <[email-masked]>
> Signed-off-by: Boris Pismenny <[email-masked]>
> Signed-off-by: Or Gerlitz <[email-masked]>
> Signed-off-by: Yoray Zack <[email-masked]>
> Signed-off-by: Shai Malin <[email-masked]>
> Signed-off-by: Aurelien Aptel <[email-masked]>

Great stuff :) Please get someone who matters to ack this.

> Reviewed-by: Chaitanya Kulkarni <[email-masked]>
> ---
>  lib/iov_iter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/iov_iter.c b/lib/iov_iter.c
> index c3ca28ca68a6..75470a4b8ab3 100644
> --- a/lib/iov_iter.c
> +++ b/lib/iov_iter.c
> @@ -526,7 +526,7 @@ size_t _copy_to_iter(const void *addr, size_t bytes, struct iov_iter *i)
>  		might_fault();
>  	iterate_and_advance(i, bytes, base, len, off,
>  		copyout(base, addr + off, len),
> -		memcpy(base, addr + off, len)
> +		(base != addr + off) && memcpy(base, addr + off, len)