Subject: Re: [Patch net] kcm: fix a race condition in kcm_recvmsg()

From: Jakub Kicinski <[email-masked]>
Date: Tue, 25 Oct 2022 16:02:22 -0700

On Sat, 22 Oct 2022 19:30:44 -0700 Cong Wang wrote:
> +			spin_lock_bh(&mux->rx_lock);
>  			KCM_STATS_INCR(kcm->stats.rx_msgs);
>  			skb_unlink(skb, &sk->sk_receive_queue);
> +			spin_unlock_bh(&mux->rx_lock);

Why not switch to __skb_unlink() at the same time?
Abundance of caution?

Adding Eric who was fixing KCM bugs recently.