Subject: Re: [PATCH v2 net-next 3/5] ionic: new ionic device identity level and VF start control

From: Jakub Kicinski <[email-masked]>
Date: Tue, 25 Oct 2022 20:08:11 -0700

On Tue, 25 Oct 2022 04:24:24 -0700 Shannon Nelson wrote:
> A new ionic dev_cmd is added to the interface in ionic_if.h,
> with a new capabilities field in the ionic device identity to
> signal its availability in the FW.  The identity level code is
> incremented to '2' to show support for this new capabilities
> bitfield.
> 
> If the driver has indicated with the new identity level that
> it has the VF_CTRL command, newer FW will wait for the start
> command before starting the VFs after a FW update or crash
> recovery.
> 
> This patch updates the driver to make use of the new VF start
> control in fw_up path to be sure that the PF has set the user
> attributes on the VF before the FW allows the VFs to restart.

You need to tidy up the kdoc usage..

> @@ -54,6 +54,7 @@ enum ionic_cmd_opcode {
>  	/* SR/IOV commands */
>  	IONIC_CMD_VF_GETATTR			= 60,
>  	IONIC_CMD_VF_SETATTR			= 61,
> +	IONIC_CMD_VF_CTRL			= 62,

not documented

>  
>  	/* QoS commands */
>  	IONIC_CMD_QOS_CLASS_IDENTIFY		= 240,

> +/**
> + * struct ionic_vf_ctrl_cmd - VF control command
> + * @opcode:         Opcode for the command
> + * @vf_index:       VF Index. It is unused if op START_ALL is used.
> + * @ctrl_opcode:    VF control operation type
> + */
> +struct ionic_vf_ctrl_cmd {
> +	u8	opcode;
> +	u8	ctrl_opcode;
> +	__le16	vf_index;
> +	u8	rsvd1[60];

not documented

> +};
> +
> +/**
> + * struct ionic_vf_ctrl_comp - VF_CTRL command completion.
> + * @status:     Status of the command (enum ionic_status_code)
> + */
> +struct ionic_vf_ctrl_comp {
> +	u8	status;
> +	u8      rsvd[15];
> +};

not documented

For the rsvd fields you can use the /* private: */ comment,
see the docs.