Subject: Re: [PATCH net-next v4] ethtool: linkstate: add a statistic for PHY down events

From: Jakub Kicinski <[email-masked]>
Date: Wed, 2 Nov 2022 09:31:33 -0700

On Tue,  1 Nov 2022 20:57:04 -0700 Jakub Kicinski wrote:
> +	 * This statistic counts when PHY _actually_ went down, or lost link.
> +	 */

Please ignore, I just realized I forgot to commit the change:

diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
index fa8e0d52dd30..15c0134ae938 100644
--- a/include/linux/ethtool.h
+++ b/include/linux/ethtool.h
@@ -132,6 +132,9 @@ struct ethtool_link_ext_stats {
         * actually take the physical link down, not to mention NC-SI which,
         * if present, keeps the link up regardless of host state.
         * This statistic counts when PHY _actually_ went down, or lost link.
+        *
+        * Note that we need u64 for ethtool_stats_init() and comparisons
+        * to ETHTOOL_STAT_NOT_SET, only u32 is exposed to the user.
         */
        u64 link_down_events;
 };