From: Yang Li <yang.lee@linux•alibaba.com>
To: davem@davemloft•net
Cc: edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
richardcochran@gmail•com, netdev@vger•kernel.org,
linux-renesas-soc@vger•kernel.org, linux-kernel@vger•kernel.org,
Yang Li <yang.lee@linux•alibaba.com>,
Abaci Robot <abaci@linux•alibaba.com>
Subject: [PATCH -next] net: ethernet: Simplify bool conversion
Date: Fri, 4 Nov 2022 09:06:35 +0800 [thread overview]
Message-ID: <20221104010635.68515-1-yang.lee@linux.alibaba.com> (raw)
./drivers/net/ethernet/renesas/rcar_gen4_ptp.c:32:40-45: WARNING: conversion to bool not needed here
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2729
Reported-by: Abaci Robot <abaci@linux•alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux•alibaba.com>
---
drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
index c007e33c47e1..37f7359678e5 100644
--- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
+++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c
@@ -29,7 +29,7 @@ static const struct rcar_gen4_ptp_reg_offset s4_offs = {
static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
{
struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp);
- bool neg_adj = scaled_ppm < 0 ? true : false;
+ bool neg_adj = scaled_ppm < 0;
s64 addend = ptp_priv->default_addend;
s64 diff;
--
2.20.1.7.g153144c
next reply other threads:[~2022-11-04 1:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 1:06 Yang Li [this message]
2022-11-04 2:16 ` [PATCH -next] net: ethernet: Simplify bool conversion Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104010635.68515-1-yang.lee@linux.alibaba.com \
--to=yang.lee@linux$(echo .)alibaba.com \
--cc=abaci@linux$(echo .)alibaba.com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox