Subject: Re: [PATCH net-next v9 1/9] devlink: Introduce new attribute 'tx_priority' to devlink-rate

From: Jakub Kicinski <[email-masked]>
Date: Fri, 4 Nov 2022 19:07:24 -0700

On Fri,  4 Nov 2022 15:30:54 +0100 Michal Wilczynski wrote:
> +	DEVLINK_ATTR_RATE_TX_PRIORITY,		/* u16 */

All netlink attributes are padded out to 4 bytes, please make this u32,
you shouldn't use smaller values at netlink level unless it's carrying
protocol fields with fixed width.

> +	int (*rate_leaf_tx_priority_set)(struct devlink_rate *devlink_rate, void *priv,
> +					 u64 tx_priority, struct netlink_ext_ack *extack);

And why make the driver API u64?