From: Jakub Kicinski <kuba@kernel•org>
To: Mengyuan Lou <mengyuanlou@net-swift•com>
Cc: netdev@vger•kernel.org, jiawenwu@trustnetic•com
Subject: Re: [PATCH net-next 2/5] net: txgbe: Initialize service task
Date: Tue, 8 Nov 2022 15:55:45 -0800 [thread overview]
Message-ID: <20221108155545.79373df2@kernel.org> (raw)
In-Reply-To: <20221108111907.48599-3-mengyuanlou@net-swift.com>
On Tue, 8 Nov 2022 19:19:04 +0800 Mengyuan Lou wrote:
> + __TXGBE_TESTING,
> + __TXGBE_RESETTING,
> + __TXGBE_DOWN,
> + __TXGBE_HANGING,
> + __TXGBE_DISABLED,
> + __TXGBE_REMOVING,
> + __TXGBE_SERVICE_SCHED,
> + __TXGBE_SERVICE_INITED,
Please don't try to implement a state machine in the driver.
Protect data structures with locks, like a normal piece of SW.
next prev parent reply other threads:[~2022-11-08 23:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 11:19 [PATCH net-next 0/5] net: WangXun ethernet drivers Mengyuan Lou
2022-11-08 11:19 ` [PATCH net-next 1/5] net: txgbe: Identify PHY and SFP module Mengyuan Lou
2022-11-08 20:52 ` Andrew Lunn
2022-11-09 6:32 ` Jiawen Wu
2022-11-09 13:26 ` Andrew Lunn
2022-11-14 9:34 ` Jiawen Wu
2022-11-14 13:25 ` Andrew Lunn
2022-11-29 8:20 ` Jiawen Wu
2022-11-14 15:34 ` Alexander Lobakin
2022-11-14 20:18 ` Andrew Lunn
2022-11-08 11:19 ` [PATCH net-next 2/5] net: txgbe: Initialize service task Mengyuan Lou
2022-11-08 23:55 ` Jakub Kicinski [this message]
2022-11-09 2:16 ` Jiawen Wu
2022-11-09 2:36 ` Andrew Lunn
2022-11-14 15:39 ` Alexander Lobakin
2022-11-08 11:19 ` [PATCH net-next 3/5] net: txgbe: Support to setup link Mengyuan Lou
2022-11-08 21:03 ` Andrew Lunn
2022-11-14 15:48 ` Alexander Lobakin
2022-11-14 20:20 ` Andrew Lunn
2022-11-08 11:19 ` [PATCH net-next 4/5] net: ngbe: Initialize phy information Mengyuan Lou
2022-11-08 21:10 ` Andrew Lunn
2022-11-11 3:13 ` mengyuanlou
2022-11-11 3:28 ` Andrew Lunn
2022-11-14 16:16 ` Alexander Lobakin
2022-11-08 11:19 ` [PATCH net-next 5/5] net: ngbe: Initialize service task Mengyuan Lou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108155545.79373df2@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=jiawenwu@trustnetic$(echo .)com \
--cc=mengyuanlou@net-swift$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox