Subject: Re: [PATCH net-next 2/5] net: txgbe: Initialize service task

From: Jakub Kicinski <[email-masked]>
Date: Tue, 8 Nov 2022 15:55:45 -0800

On Tue,  8 Nov 2022 19:19:04 +0800 Mengyuan Lou wrote:
> +	__TXGBE_TESTING,
> +	__TXGBE_RESETTING,
> +	__TXGBE_DOWN,
> +	__TXGBE_HANGING,
> +	__TXGBE_DISABLED,
> +	__TXGBE_REMOVING,
> +	__TXGBE_SERVICE_SCHED,
> +	__TXGBE_SERVICE_INITED,

Please don't try to implement a state machine in the driver.
Protect data structures with locks, like a normal piece of SW.