From: Jakub Kicinski <kuba@kernel•org>
To: Zhengchao Shao <shaozhengchao@huawei•com>
Cc: <netdev@vger•kernel.org>, <sebastian.hesselbarth@gmail•com>,
<davem@davemloft•net>, <edumazet@google•com>, <pabeni@redhat•com>,
<jeffrey.t.kirsher@intel•com>, <weiyongjun1@huawei•com>,
<yuehaibing@huawei•com>
Subject: Re: [PATCH net] net: mv643xx_eth: disable napi when init rxq or txq failed in mv643xx_eth_open()
Date: Tue, 8 Nov 2022 17:27:07 -0800 [thread overview]
Message-ID: <20221108172707.732325ce@kernel.org> (raw)
In-Reply-To: <20221108025156.327279-1-shaozhengchao@huawei.com>
On Tue, 8 Nov 2022 10:51:56 +0800 Zhengchao Shao wrote:
> When failed to init rxq or txq in mv643xx_eth_open() for opening device,
> napi isn't disabled. When open mv643xx_eth device next time, it will
> report a invalid opcode issue.
It will trigger a BUG_ON() in napi_enable()
> Fix it. Only be compiled, not be tested.
Please replace "Fix it. Only be compiled, not be tested."
with "Compile tested only."
> Fixes: 527a626601de ("skge/sky2/mv643xx/pxa168: Move the Marvell Ethernet drivers")
This is not the commit which added this code, please find out where
the code was added.
next prev parent reply other threads:[~2022-11-09 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 2:51 [PATCH net] net: mv643xx_eth: disable napi when init rxq or txq failed in mv643xx_eth_open() Zhengchao Shao
2022-11-09 1:27 ` Jakub Kicinski [this message]
2022-11-09 1:42 ` shaozhengchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108172707.732325ce@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=shaozhengchao@huawei$(echo .)com \
--cc=weiyongjun1@huawei$(echo .)com \
--cc=yuehaibing@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox