From: Jakub Kicinski <kuba@kernel•org>
To: Yury Norov <yury.norov@gmail•com>
Cc: linux-kernel@vger•kernel.org,
"David S. Miller" <davem@davemloft•net>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
Barry Song <baohua@kernel•org>, Ben Segall <bsegall@google•com>,
Daniel Bristot de Oliveira <bristot@redhat•com>,
Dietmar Eggemann <dietmar.eggemann@arm•com>,
Gal Pressman <gal@nvidia•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Heiko Carstens <hca@linux•ibm.com>,
Ingo Molnar <mingo@redhat•com>, Jason Gunthorpe <jgg@nvidia•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Jonathan Cameron <Jonathan.Cameron@huawei•com>,
Juri Lelli <juri.lelli@redhat•com>,
Leon Romanovsky <leonro@nvidia•com>, Mel Gorman <mgorman@suse•de>,
Peter Zijlstra <peterz@infradead•org>,
Rasmus Villemoes <linux@rasmusvillemoes•dk>,
Saeed Mahameed <saeedm@nvidia•com>,
Steven Rostedt <rostedt@goodmis•org>,
Tariq Toukan <tariqt@nvidia•com>,
Tariq Toukan <ttoukan.linux@gmail•com>,
Tony Luck <tony.luck@intel•com>,
Valentin Schneider <vschneid@redhat•com>,
Vincent Guittot <vincent.guittot@linaro•org>,
linux-crypto@vger•kernel.org, netdev@vger•kernel.org,
linux-rdma@vger•kernel.org
Subject: Re: [PATCH 0/4] cpumask: improve on cpumask_local_spread() locality
Date: Fri, 11 Nov 2022 08:25:51 -0800 [thread overview]
Message-ID: <20221111082551.7e71fbf4@kernel.org> (raw)
In-Reply-To: <20221111040027.621646-1-yury.norov@gmail.com>
On Thu, 10 Nov 2022 20:00:23 -0800 Yury Norov wrote:
> cpumask_local_spread() currently checks local node for presence of i'th
> CPU, and then if it finds nothing makes a flat search among all non-local
> CPUs. We can do it better by checking CPUs per NUMA hops.
Nice.
> This series is inspired by Valentin Schneider's "net/mlx5e: Improve remote
> NUMA preferences used for the IRQ affinity hints"
>
> https://patchwork.kernel.org/project/netdevbpf/patch/20220728191203.4055-3-tariqt@nvidia.com/
>
> According to Valentin's measurements, for mlx5e:
>
> Bottleneck in RX side is released, reached linerate (~1.8x speedup).
> ~30% less cpu util on TX.
>
> This patch makes cpumask_local_spread() traversing CPUs based on NUMA
> distance, just as well, and I expect comparabale improvement for its
> users, as in Valentin's case.
>
> I tested it on my VM with the following NUMA configuration:
nit: the authorship is a bit more complicated, it'd be good to mention
Tariq. Both for the code and attribution of the testing / measurements.
next prev parent reply other threads:[~2022-11-11 16:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 4:00 [PATCH 0/4] cpumask: improve on cpumask_local_spread() locality Yury Norov
2022-11-11 4:00 ` [PATCH 1/4] lib/find: introduce find_nth_and_andnot_bit Yury Norov
2022-11-11 4:00 ` [PATCH 2/4] cpumask: introduce cpumask_nth_and_andnot() Yury Norov
2022-11-11 4:00 ` [PATCH 3/4] sched: add sched_numa_find_nth_cpu() Yury Norov
2022-11-11 4:11 ` Yury Norov
2022-11-11 11:42 ` Andy Shevchenko
2022-11-11 17:07 ` Yury Norov
2022-11-11 18:14 ` Andy Shevchenko
2022-11-12 18:14 ` Yury Norov
2022-11-11 4:00 ` [PATCH 4/4] cpumask: improve on cpumask_local_spread() locality Yury Norov
2022-11-11 16:25 ` Jakub Kicinski [this message]
[not found] ` <CAAH8bW9jG5US0Ymn1wax9tNK3MgZpcWfQsYgu-Km_E+WZw3yiA@mail.gmail.com>
2022-11-13 7:37 ` [PATCH 0/4] " Tariq Toukan
2022-11-13 12:29 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221111082551.7e71fbf4@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Jonathan.Cameron@huawei$(echo .)com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=baohua@kernel$(echo .)org \
--cc=bristot@redhat$(echo .)com \
--cc=bsegall@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dietmar.eggemann@arm$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hca@linux$(echo .)ibm.com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jgg@nvidia$(echo .)com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=leonro@nvidia$(echo .)com \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=mgorman@suse$(echo .)de \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=saeedm@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=tony.luck@intel$(echo .)com \
--cc=ttoukan.linux@gmail$(echo .)com \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=vschneid@redhat$(echo .)com \
--cc=yury.norov@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox