Subject: Re: [PATCH net-next 2/3] net: qualcomm: rmnet: add tx packets aggregation

From: Jakub Kicinski <[email-masked]>
Date: Fri, 11 Nov 2022 09:14:40 -0800

On Wed,  9 Nov 2022 19:02:48 +0100 Daniele Palmas wrote:
> +bool rmnet_map_tx_agg_skip(struct sk_buff *skb)
> +{
> +	bool is_icmp = 0;
> +
> +	if (skb->protocol == htons(ETH_P_IP)) {
> +		struct iphdr *ip4h = ip_hdr(skb);
> +
> +		if (ip4h->protocol == IPPROTO_ICMP)
> +			is_icmp = true;
> +	} else if (skb->protocol == htons(ETH_P_IPV6)) {
> +		unsigned int icmp_offset = 0;
> +
> +		if (ipv6_find_hdr(skb, &icmp_offset, IPPROTO_ICMPV6, NULL, NULL) == IPPROTO_ICMPV6)
> +			is_icmp = true;
> +	}
> +
> +	return is_icmp;
> +}

Why this? I don't see it mention in the commit message or any code
comment.