Subject: Re: [PATCH net-next v3] ethtool: add netlink based get rss support

From: Jakub Kicinski <[email-masked]>
Date: Thu, 17 Nov 2022 20:08:45 -0800

On Wed, 16 Nov 2022 15:25:54 -0800 Sudheer Mogilappagari wrote:
> +RSS_GET
> +========

One too many =

> +	{
> +		.cmd	= ETHTOOL_MSG_RSS_GET,
> +		.doit	= ethnl_default_doit,
> +		.start	= ethnl_default_start,
> +		.done	= ethnl_default_done,

start and done are part of the dump procedure, since we have no dump
now I think we should drop those

> +		.policy = ethnl_rss_get_policy,
> +		.maxattr = ARRAY_SIZE(ethnl_rss_get_policy) - 1,
> +	},
>  };