Subject: Re: [PATCH net-next 2/8] devlink: use min_t to calculate data_size

From: Jakub Kicinski <[email-masked]>
Date: Mon, 21 Nov 2022 11:06:02 -0800

On Mon, 21 Nov 2022 10:35:34 -0800 Jacob Keller wrote:
> > Sure, that makes sense.
> 
> This becomes the only variable in patch 5 of 8. It ends up making the 
> diff look more complicated if I change it back to a combined 
> declare+assign in that patch.

Don't change it back to declare+assign, then? :)
In general declare+assign should be used sparingly IMO.
My eyes are trained to skip right past the variable declarations,
the goal is to make the code clear, not short :S

BTW you can probably make DEVLINK_REGION_READ_CHUNK_SIZE a ULL to switch
from min_t() to min() ?