From: Jakub Kicinski <kuba@kernel•org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
Cc: linux-kernel@vger•kernel.org,
"Rafael J. Wysocki" <rafael@kernel•org>,
Trond Myklebust <trond.myklebust@hammerspace•com>,
Anna Schumaker <anna@kernel•org>, Roopa Prabhu <roopa@nvidia•com>,
Nikolay Aleksandrov <razor@blackwall•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Chuck Lever <chuck.lever@oracle•com>,
Jeff Layton <jlayton@kernel•org>,
linux-nfs@vger•kernel.org, bridge@lists•linux-foundation.org,
netdev@vger•kernel.org
Subject: Re: [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject *
Date: Mon, 21 Nov 2022 12:18:03 -0800 [thread overview]
Message-ID: <20221121121803.31962489@kernel.org> (raw)
In-Reply-To: <20221121094649.1556002-1-gregkh@linuxfoundation.org>
On Mon, 21 Nov 2022 10:46:45 +0100 Greg Kroah-Hartman wrote:
> The call, kobject_get_ownership(), does not modify the kobject passed
> into it, so make it const. This propagates down into the kobj_type
> function callbacks so make the kobject passed into them also const,
> ensuring that nothing in the kobject is being changed here.
>
> This helps make it more obvious what calls and callbacks do, and do not,
> modify structures passed to them.
Acked-by: Jakub Kicinski <kuba@kernel•org>
prev parent reply other threads:[~2022-11-21 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 9:46 [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject * Greg Kroah-Hartman
2022-11-21 10:53 ` Nikolay Aleksandrov
2022-11-21 11:48 ` Rafael J. Wysocki
2022-11-21 20:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121121803.31962489@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=anna@kernel$(echo .)org \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=chuck.lever@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jlayton@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=razor@blackwall$(echo .)org \
--cc=roopa@nvidia$(echo .)com \
--cc=trond.myklebust@hammerspace$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox