Subject: Re: [net 04/14] net/mlx5: cmdif, Print info on any firmware cmd failure to tracepoint

From: Jakub Kicinski <[email-masked]>
Date: Wed, 23 Nov 2022 17:55:50 -0800

On Wed, 23 Nov 2022 15:48:07 -0800 Saeed Mahameed wrote:
> >> While moving to new CMD API (quiet API), some pre-existing flows may call the new API
> >> function that in case of error, returns the error instead of printing it as previously done.
> >> For such flows we bring back the print but to tracepoint this time for sys admins to
> >> have the ability to check for errors especially for commands using the new quiet API.
> >
> > WARNING: Possible unwrapped commit description (prefer a maximum 75 chars
> > per line)
> 
> we don't enforce this in netdev, especially when you want to share output,
> etc .. 

Maciej is right, it's one of those things I don't have stamina to
enforce. But you just gave me motivation, please start complying with
the rules.

> also for future reference in mlx5 we allow up to 95 chars per code line, we
> got wide screens :P, so also please ignore these warnings.

"We got wide screens"? Your inability to write concise code is
certainly not a virtue. Don't be flippant about it :/