Subject: Re: [RFC PATCH net-next 08/19] pds_core: initial VF configuration

From: Jakub Kicinski <[email-masked]>
Date: Mon, 28 Nov 2022 10:28:28 -0800

On Fri, 18 Nov 2022 14:56:45 -0800 Shannon Nelson wrote:
> +	.ndo_set_vf_vlan	= pdsc_set_vf_vlan,
> +	.ndo_set_vf_mac		= pdsc_set_vf_mac,
> +	.ndo_set_vf_trust	= pdsc_set_vf_trust,
> +	.ndo_set_vf_rate	= pdsc_set_vf_rate,
> +	.ndo_set_vf_spoofchk	= pdsc_set_vf_spoofchk,
> +	.ndo_set_vf_link_state	= pdsc_set_vf_link_state,
> +	.ndo_get_vf_config	= pdsc_get_vf_config,
> +	.ndo_get_vf_stats       = pdsc_get_vf_stats,

These are legacy, you're adding a fancy SmartNIC (or whatever your
marketing decided to call it) driver. Please don't use these at all.