From: Jakub Kicinski <kuba@kernel•org>
To: Vincent Mailhol <mailhol.vincent@wanadoo•fr>
Cc: Jiri Pirko <jiri@nvidia•com>,
netdev@vger•kernel.org, "David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
linux-kernel@vger•kernel.org,
Boris Brezillon <bbrezillon@kernel•org>,
Arnaud Ebalard <arno@natisbad•org>,
Srujana Challa <schalla@marvell•com>,
Kurt Kanzenbach <kurt@linutronix•de>,
Andrew Lunn <andrew@lunn•ch>,
Florian Fainelli <f.fainelli@gmail•com>,
Vladimir Oltean <olteanv@gmail•com>,
Michael Chan <michael.chan@broadcom•com>,
Ioana Ciornei <ioana.ciornei@nxp•com>,
Dimitris Michailidis <dmichail@fungible•com>,
Yisen Zhuang <yisen.zhuang@huawei•com>,
Salil Mehta <salil.mehta@huawei•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Sunil Goutham <sgoutham@marvell•com>,
Linu Cherian <lcherian@marvell•com>,
Geetha sowjanya <gakula@marvell•com>,
Jerin Jacob <jerinj@marvell•com>, hariprasad <hkelam@marvell•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
Taras Chornyi <tchornyi@marvell•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Leon Romanovsky <leon@kernel•org>,
Ido Schimmel <idosch@nvidia•com>, Petr Machata <petrm@nvidia•com>,
Simon Horman <simon.horman@corigine•com>,
Shannon Nelson <snelson@pensando•io>,
drivers@pensando•io, Ariel Elior <aelior@marvell•com>,
Manish Chopra <manishc@marvell•com>,
Jonathan Lemon <jonathan.lemon@gmail•com>,
Vadim Fedorenko <vadfed@fb•com>,
Richard Cochran <richardcochran@gmail•com>,
Vadim Pasternak <vadimp@mellanox•com>,
Shalom Toledo <shalomt@mellanox•com>,
linux-crypto@vger•kernel.org, intel-wired-lan@lists•osuosl.org,
linux-rdma@vger•kernel.org, oss-drivers@corigine•com,
Jiri Pirko <jiri@mellanox•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
Hao Chen <chenhao288@hisilicon•com>,
Guangbin Huang <huangguangbin2@huawei•com>,
Minghao Chi <chi.minghao@zte•com.cn>,
Shijith Thotton <sthotton@marvell•com>
Subject: Re: [PATCH net-next v4 3/3] net: devlink: make the devlink_ops::info_get() callback optional
Date: Mon, 28 Nov 2022 10:42:03 -0800 [thread overview]
Message-ID: <20221128104203.079ce802@kernel.org> (raw)
In-Reply-To: <20221128041545.3170897-4-mailhol.vincent@wanadoo.fr>
On Mon, 28 Nov 2022 13:15:45 +0900 Vincent Mailhol wrote:
> Some drivers only reported the driver name in their
> devlink_ops::info_get() callback. Now that the core provides this
> information, the callback became empty. For such drivers, just
> removing the callback would prevent the core from executing
> devlink_nl_info_fill() meaning that "devlink dev info" would not
> return anything.
>
> Make the callback function optional by executing
> devlink_nl_info_fill() even if devlink_ops::info_get() is NULL.
>
> Remove all the empty devlink_ops::info_get() functions from the
> drivers.
>
> N.B.: the drivers with devlink support which previously did not
> implement devlink_ops::info_get() will now also be able to report
> the driver name.
These should be two separate patches, tho.
Please don't post v5 in-reply-to.
Otherwise looks good. Kinda risky but good :)
prev parent reply other threads:[~2022-11-28 18:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 15:49 [RFC PATCH] net: devlink: devlink_nl_info_fill: populate default information Vincent Mailhol
2022-11-23 4:12 ` Jakub Kicinski
2022-11-23 9:42 ` Vincent MAILHOL
2022-11-24 3:06 ` Jakub Kicinski
2022-11-24 5:33 ` Vincent MAILHOL
2022-11-24 8:53 ` Jiri Pirko
2022-11-28 18:43 ` Jakub Kicinski
2022-11-28 23:14 ` Vincent MAILHOL
2022-11-23 9:46 ` Jiri Pirko
2022-11-23 11:00 ` Vincent MAILHOL
2022-11-23 12:10 ` Jiri Pirko
2022-11-23 16:08 ` Vincent MAILHOL
2022-11-23 16:26 ` Jiri Pirko
2022-11-24 16:20 ` Vincent MAILHOL
2022-11-27 8:15 ` [PATCH net-next v2 0/5] net: devlink: return the driver name in devlink_nl_info_fill Vincent Mailhol
2022-11-27 8:16 ` [PATCH net-next v2 1/5] mlxsw: minimal: fix mlxsw_m_module_get_drvinfo() to correctly report driver name Vincent Mailhol
2022-11-27 8:16 ` [PATCH net-next v2 2/5] mlxsw: core: fix mlxsw_devlink_info_get() " Vincent Mailhol
2022-11-27 8:16 ` [PATCH net-next v2 3/5] net: devlink: let the core report the driver name instead of the drivers Vincent Mailhol
2022-11-27 8:16 ` [PATCH net-next v2 4/5] net: devlink: remove devlink_info_driver_name_put() Vincent Mailhol
2022-11-27 12:01 ` kernel test robot
2022-11-27 12:11 ` kernel test robot
2022-11-27 8:16 ` [PATCH net-next v2 5/5] net: devlink: make the devlink_ops::info_get() callback optional Vincent Mailhol
2022-11-27 13:09 ` [PATCH net-next v3 0/5] net: devlink: return the driver name in devlink_nl_info_fill Vincent Mailhol
2022-11-27 13:09 ` [PATCH net-next v3 1/5] mlxsw: minimal: fix mlxsw_m_module_get_drvinfo() to correctly report driver name Vincent Mailhol
2022-11-27 16:14 ` Ido Schimmel
2022-11-27 13:09 ` [PATCH net-next v3 2/5] mlxsw: core: fix mlxsw_devlink_info_get() " Vincent Mailhol
2022-11-27 16:17 ` Ido Schimmel
2022-11-28 1:42 ` Vincent MAILHOL
2022-11-27 13:09 ` [PATCH net-next v3 3/5] net: devlink: let the core report the driver name instead of the drivers Vincent Mailhol
2022-11-27 13:09 ` [PATCH net-next v3 4/5] net: devlink: remove devlink_info_driver_name_put() Vincent Mailhol
2022-11-27 13:09 ` [PATCH net-next v3 5/5] net: devlink: make the devlink_ops::info_get() callback optional Vincent Mailhol
2022-11-28 4:15 ` [PATCH net-next v4 0/3] net: devlink: return the driver name in devlink_nl_info_fill Vincent Mailhol
2022-11-28 4:15 ` [PATCH net-next v4 1/3] net: devlink: let the core report the driver name instead of the drivers Vincent Mailhol
2022-11-28 11:49 ` Ido Schimmel
2022-11-28 4:15 ` [PATCH net-next v4 2/3] net: devlink: remove devlink_info_driver_name_put() Vincent Mailhol
2022-11-28 4:15 ` [PATCH net-next v4 3/3] net: devlink: make the devlink_ops::info_get() callback optional Vincent Mailhol
2022-11-28 18:42 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128104203.079ce802@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=aelior@marvell$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=arno@natisbad$(echo .)org \
--cc=bbrezillon@kernel$(echo .)org \
--cc=chenhao288@hisilicon$(echo .)com \
--cc=chi.minghao@zte$(echo .)com.cn \
--cc=davem@davemloft$(echo .)net \
--cc=dmichail@fungible$(echo .)com \
--cc=drivers@pensando$(echo .)io \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=hkelam@marvell$(echo .)com \
--cc=huangguangbin2@huawei$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=jerinj@marvell$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@mellanox$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kurt@linutronix$(echo .)de \
--cc=lcherian@marvell$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=mailhol.vincent@wanadoo$(echo .)fr \
--cc=manishc@marvell$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=schalla@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=shalomt@mellanox$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=snelson@pensando$(echo .)io \
--cc=sthotton@marvell$(echo .)com \
--cc=tchornyi@marvell$(echo .)com \
--cc=vadfed@fb$(echo .)com \
--cc=vadimp@mellanox$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox