From: Christoph Hellwig <hch@lst•de>
To: Benjamin Coddington <bcodding@redhat•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
"Philipp Reisner" <philipp.reisner@linbit•com>,
"Lars Ellenberg" <lars.ellenberg@linbit•com>,
"Christoph Böhmwalder" <christoph.boehmwalder@linbit•com>,
"Jens Axboe" <axboe@kernel•dk>,
"Josef Bacik" <josef@toxicpanda•com>,
"Keith Busch" <kbusch@kernel•org>,
"Christoph Hellwig" <hch@lst•de>,
"Sagi Grimberg" <sagi@grimberg•me>,
"Lee Duncan" <lduncan@suse•com>,
"Chris Leech" <cleech@redhat•com>,
"Mike Christie" <michael.christie@oracle•com>,
"James E.J. Bottomley" <jejb@linux•ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
"Valentina Manea" <valentina.manea.m@gmail•com>,
"Shuah Khan" <shuah@kernel•org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"David Howells" <dhowells@redhat•com>,
"Marc Dionne" <marc.dionne@auristor•com>,
"Steve French" <sfrench@samba•org>,
"Christine Caulfield" <ccaulfie@redhat•com>,
"David Teigland" <teigland@redhat•com>,
"Mark Fasheh" <mark@fasheh•com>,
"Joel Becker" <jlbec@evilplan•org>,
"Joseph Qi" <joseph.qi@linux•alibaba.com>,
"Eric Van Hensbergen" <ericvh@gmail•com>,
"Latchesar Ionkov" <lucho@ionkov•net>,
"Dominique Martinet" <asmadeus@codewreck•org>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Ilya Dryomov" <idryomov@gmail•com>,
"Xiubo Li" <xiubli@redhat•com>,
"Trond Myklebust" <trond.myklebust@hammerspace•com>,
"Anna Schumaker" <anna@kernel•org>,
"Chuck Lever" <chuck.lever@oracle•com>,
"Jeff Layton" <jlayton@kernel•org>,
drbd-dev@lists•linbit.com, linux-block@vger•kernel.org,
nbd@other•debian.org, linux-nvme@lists•infradead.org,
open-iscsi@googlegroups•com, linux-scsi@vger•kernel.org,
linux-usb@vger•kernel.org, linux-afs@lists•infradead.org,
linux-cifs@vger•kernel.org, samba-technical@lists•samba.org,
cluster-devel@redhat•com, ocfs2-devel@oss•oracle.com,
v9fs-developer@lists•sourceforge.net, ceph-devel@vger•kernel.org,
linux-nfs@vger•kernel.org
Subject: Re: [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag
Date: Tue, 29 Nov 2022 15:02:42 +0100 [thread overview]
Message-ID: <20221129140242.GA15747@lst.de> (raw)
In-Reply-To: <c2ec184226acd21a191ccc1aa46a1d7e43ca7104.1669036433.git.bcodding@redhat.com>
Hmm. Having to set a flag to not accidentally corrupt per-task
state seems a bit fragile. Wouldn't it make sense to find a way to opt
into the feature only for sockets created from the syscall layer?
next prev parent reply other threads:[~2022-11-29 14:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 13:35 [PATCH v1 0/3] Stop corrupting socket's task_frag Benjamin Coddington
2022-11-21 13:35 ` [PATCH v1 1/3] net: Introduce sk_use_task_frag in struct sock Benjamin Coddington
2022-12-09 12:09 ` Paolo Abeni
2022-12-09 14:16 ` Eric Dumazet
2022-11-21 13:35 ` [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag Benjamin Coddington
2022-11-21 13:56 ` David Howells
2022-11-21 14:34 ` Benjamin Coddington
2022-11-21 21:40 ` Shuah Khan
2022-11-21 21:43 ` Shuah Khan
2022-11-21 22:01 ` Benjamin Coddington
2022-11-21 22:32 ` Shuah Khan
2022-11-22 14:23 ` Benjamin Coddington
2022-11-29 14:02 ` Christoph Hellwig [this message]
2022-11-29 16:47 ` Benjamin Coddington
2022-11-30 12:07 ` Guillaume Nault
2022-11-29 17:42 ` Jeff Layton
2022-11-30 11:48 ` Guillaume Nault
2022-12-09 12:37 ` Paolo Abeni
2022-12-09 16:11 ` Jakub Kicinski
2022-12-09 16:50 ` Paolo Abeni
2022-11-21 13:35 ` [PATCH v1 3/3] net: simplify sk_page_frag Benjamin Coddington
2022-12-09 16:42 ` Paolo Abeni
2022-12-09 16:44 ` Paolo Abeni
2022-12-09 16:44 ` Paolo Abeni
2022-12-07 11:44 ` [PATCH v1 0/3] Stop corrupting socket's task_frag Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221129140242.GA15747@lst.de \
--to=hch@lst$(echo .)de \
--cc=anna@kernel$(echo .)org \
--cc=asmadeus@codewreck$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=bcodding@redhat$(echo .)com \
--cc=ccaulfie@redhat$(echo .)com \
--cc=ceph-devel@vger$(echo .)kernel.org \
--cc=christoph.boehmwalder@linbit$(echo .)com \
--cc=chuck.lever@oracle$(echo .)com \
--cc=cleech@redhat$(echo .)com \
--cc=cluster-devel@redhat$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dhowells@redhat$(echo .)com \
--cc=drbd-dev@lists$(echo .)linbit.com \
--cc=edumazet@google$(echo .)com \
--cc=ericvh@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=idryomov@gmail$(echo .)com \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jlayton@kernel$(echo .)org \
--cc=jlbec@evilplan$(echo .)org \
--cc=josef@toxicpanda$(echo .)com \
--cc=joseph.qi@linux$(echo .)alibaba.com \
--cc=kbusch@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lars.ellenberg@linbit$(echo .)com \
--cc=lduncan@suse$(echo .)com \
--cc=linux-afs@lists$(echo .)infradead.org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-cifs@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=linux-nvme@lists$(echo .)infradead.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=lucho@ionkov$(echo .)net \
--cc=marc.dionne@auristor$(echo .)com \
--cc=mark@fasheh$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=michael.christie@oracle$(echo .)com \
--cc=nbd@other$(echo .)debian.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ocfs2-devel@oss$(echo .)oracle.com \
--cc=open-iscsi@googlegroups$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=philipp.reisner@linbit$(echo .)com \
--cc=sagi@grimberg$(echo .)me \
--cc=samba-technical@lists$(echo .)samba.org \
--cc=sfrench@samba$(echo .)org \
--cc=shuah@kernel$(echo .)org \
--cc=teigland@redhat$(echo .)com \
--cc=trond.myklebust@hammerspace$(echo .)com \
--cc=v9fs-developer@lists$(echo .)sourceforge.net \
--cc=valentina.manea.m@gmail$(echo .)com \
--cc=xiubli@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox