Subject: Re: [PATCH net-next v7] ethtool: add netlink based get rss support

From: Jakub Kicinski <[email-masked]>
Date: Sun, 4 Dec 2022 15:38:50 -0800

On Sun, 4 Dec 2022 14:17:05 +0200 Leon Romanovsky wrote:
> On Thu, Dec 01, 2022 at 04:25:55PM -0800, Sudheer Mogilappagari wrote:
> > Add netlink based support for "ethtool -x <dev> [context x]"
> > command by implementing ETHTOOL_MSG_RSS_GET netlink message.
> > This is equivalent to functionality provided via ETHTOOL_GRSSH
> > in ioctl path. It sends RSS table, hash key and hash function
> > of an interface to user space.
> > 
> > This patch implements existing functionality available
> > in ioctl path and enables addition of new RSS context
> > based parameters in future.  
> 
> But why do you do this conversion now? Was this "future" already
> discussed on the ML?

Conversion to netlink stands on its own.

> > +	u8 *rss_config;
> > +	int ret;  
> 
> <...>
> 
> > +		data->indir_table = (u32 *)rss_config;  
> 
> Please use correct type from the beginning.

There are two tables in this memory, the second one is u8.
So one of them will need the cast, the code is fine AFAICT.