Subject: Re: [net-next 14/15] net/mlx5: SRIOV, Add 802.1ad VST support

From: Jakub Kicinski <[email-masked]>
Date: Tue, 6 Dec 2022 20:34:14 -0800

On Sat,  3 Dec 2022 14:13:36 -0800 Saeed Mahameed wrote:
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> index 8d36e2de53a9..7911edefc622 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> @@ -4440,11 +4440,8 @@ static int mlx5e_set_vf_vlan(struct net_device *dev, int vf, u16 vlan, u8 qos,
>  	struct mlx5e_priv *priv = netdev_priv(dev);
>  	struct mlx5_core_dev *mdev = priv->mdev;
>  
> -	if (vlan_proto != htons(ETH_P_8021Q))
> -		return -EPROTONOSUPPORT;

I can't take this with clear conscience :( I started nacking any new use
of the legacy VF NDOs. You already have bridging offload implemented,
why can bridging be used?

>  	return mlx5_eswitch_set_vport_vlan(mdev->priv.eswitch, vf + 1,
> -					   vlan, qos);
> +					   vlan, qos, ntohs(vlan_proto));
>  }
>