From: Jakub Kicinski <kuba@kernel•org>
To: Kees Cook <keescook@chromium•org>
Cc: syzbot+fda18eaa8c12534ccb3b@syzkaller•appspotmail.com,
Eric Dumazet <edumazet@google•com>,
"David S. Miller" <davem@davemloft•net>,
Paolo Abeni <pabeni@redhat•com>,
Pavel Begunkov <asml.silence@gmail•com>,
pepsipu <soopthegoop@gmail•com>, Vlastimil Babka <vbabka@suse•cz>,
kasan-dev <kasan-dev@googlegroups•com>,
Andrii Nakryiko <andrii@kernel•org>,
ast@kernel•org, bpf <bpf@vger•kernel.org>,
Daniel Borkmann <daniel@iogearbox•net>,
Hao Luo <haoluo@google•com>,
Jesper Dangaard Brouer <hawk@kernel•org>,
John Fastabend <john.fastabend@gmail•com>,
jolsa@kernel•org, KP Singh <kpsingh@kernel•org>,
martin.lau@linux•dev, Stanislav Fomichev <sdf@google•com>,
song@kernel•org, Yonghong Song <yhs@fb•com>,
netdev@vger•kernel.org, LKML <linux-kernel@vger•kernel.org>,
Rasesh Mody <rmody@marvell•com>, Ariel Elior <aelior@marvell•com>,
Manish Chopra <manishc@marvell•com>,
Menglong Dong <imagedong@tencent•com>,
David Ahern <dsahern@kernel•org>,
Richard Gobert <richardbgobert@gmail•com>,
David Rientjes <rientjes@google•com>,
Andrey Konovalov <andreyknvl@gmail•com>,
GR-Linux-NIC-Dev@marvell•com, linux-hardening@vger•kernel.org
Subject: Re: [PATCH net-next v2] skbuff: Introduce slab_build_skb()
Date: Wed, 7 Dec 2022 18:34:40 -0800 [thread overview]
Message-ID: <20221207183440.4c80918b@kernel.org> (raw)
In-Reply-To: <20221208000209.gonna.368-kees@kernel.org>
On Wed, 7 Dec 2022 16:02:13 -0800 Kees Cook wrote:
> Is this what you had in mind for this kind of change?
nice, thanks a lot!
the only thing left to do is kdoc updates:
- the existing kdocs should no longer mention frag_size == 0
- kdoc on the slab_build_skb() should say:
/* build_skb() variant which can operate on slab buffers.
* Note that this should be used sparingly as slab buffers
* cannot be combined efficiently by GRO!
*/
But this can all be done by us in a follow up, there's probably
more cleaning we can do in those kdocs.
> v2: introduce separate helper (kuba)
> v1: https://lore.kernel.org/netdev/20221206231659.never.929-kees@kernel.org/
prev parent reply other threads:[~2022-12-08 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 0:02 [PATCH net-next v2] skbuff: Introduce slab_build_skb() Kees Cook
2022-12-08 2:34 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221207183440.4c80918b@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=GR-Linux-NIC-Dev@marvell$(echo .)com \
--cc=aelior@marvell$(echo .)com \
--cc=andreyknvl@gmail$(echo .)com \
--cc=andrii@kernel$(echo .)org \
--cc=asml.silence@gmail$(echo .)com \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=haoluo@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=imagedong@tencent$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kasan-dev@googlegroups$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kpsingh@kernel$(echo .)org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=manishc@marvell$(echo .)com \
--cc=martin.lau@linux$(echo .)dev \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=richardbgobert@gmail$(echo .)com \
--cc=rientjes@google$(echo .)com \
--cc=rmody@marvell$(echo .)com \
--cc=sdf@google$(echo .)com \
--cc=song@kernel$(echo .)org \
--cc=soopthegoop@gmail$(echo .)com \
--cc=syzbot+fda18eaa8c12534ccb3b@syzkaller$(echo .)appspotmail.com \
--cc=vbabka@suse$(echo .)cz \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox