From: Stephen Hemminger <stephen@networkplumber•org>
To: Eric Dumazet <edumazet@google•com>
Cc: Jakub Sitnicki <jakub@cloudflare•com>,
Neal Cardwell <ncardwell@google•com>,
Weiping Zhang <zhangweiping@didiglobal•com>,
davem@davemloft•net, yoshfuji@linux-ipv6•org, dsahern@kernel•org,
kuba@kernel•org, pabeni@redhat•com, netdev@vger•kernel.org,
zwp10758@gmail•com
Subject: Re: [RFC PATCH] tcp: correct srtt and mdev_us calculation
Date: Sun, 11 Dec 2022 09:04:56 -0800 [thread overview]
Message-ID: <20221211090456.652eda22@hermes.local> (raw)
In-Reply-To: <CANn89i+nT61qvE3iChGc-bYiTCzR=x2ZhvddRD0qDUTF6JuK+g@mail.gmail.com>
On Sat, 10 Dec 2022 18:45:56 +0100
Eric Dumazet <edumazet@google•com> wrote:
> On Tue, Dec 6, 2022 at 10:29 AM Jakub Sitnicki <jakub@cloudflare•com> wrote:
>
>
> > Nifty. And it's documented.
> >
> > struct tcp_sock {
> > …
> > u32 srtt_us; /* smoothed round trip time << 3 in usecs */
> >
> > Thanks for the hint.
>
> The >> 3 is all over the place... So even without a formal comment,
> anyone familiar with TCP stack would spot this...
And it should be in every text book already and is in BSD as well.
Maybe a link to the SIGCOMM paper would be good for those
google deprived people?
next prev parent reply other threads:[~2022-12-11 17:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 17:59 [RFC PATCH] tcp: correct srtt and mdev_us calculation Weiping Zhang
2022-12-05 18:27 ` Eric Dumazet
2022-12-05 19:15 ` Neal Cardwell
2022-12-06 9:11 ` Jakub Sitnicki
2022-12-10 13:35 ` Weiping Zhang
2022-12-10 17:45 ` Eric Dumazet
2022-12-11 17:04 ` Stephen Hemminger [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-12-05 18:07 Weiping Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221211090456.652eda22@hermes.local \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=jakub@cloudflare$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=ncardwell@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
--cc=zhangweiping@didiglobal$(echo .)com \
--cc=zwp10758@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox