Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of value and mask

From: Jakub Kicinski <[email-masked]>
Date: Mon, 12 Dec 2022 13:02:24 -0800

On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote:
>  	case VCAP_FIELD_U128:
> +		value = data->u128.value;
> +		mask = data->u128.value;

If setting both to value is intentional - please mention in the commit
message. Otherwise this looks odd.