Subject: Re: [PATCH bpf-next v5 07/17] bpf: XDP metadata RX kfuncs

From: kernel test robot <[email-masked]>
Date: Wed, 21 Dec 2022 13:43:08 +0800

Hi Stanislav,

I love your patch! Perhaps something to improve:

[auto build test WARNING on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/xdp-hints-via-kfuncs/20221221-110542
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/20221220222043.3348718-8-sdf%40google.com
patch subject: [PATCH bpf-next v5 07/17] bpf: XDP metadata RX kfuncs
config: ia64-allyesconfig
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/f0946bf20669262734baef03ae12ef189c9c9292
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Stanislav-Fomichev/xdp-hints-via-kfuncs/20221221-110542
        git checkout f0946bf20669262734baef03ae12ef189c9c9292
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash kernel/bpf/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email-masked]>

All warnings (new ones prefixed by >>):

>> kernel/bpf/verifier.c:2084:5: warning: no previous prototype for 'bpf_dev_bound_kfunc_check' [-Wmissing-prototypes]
    2084 | int bpf_dev_bound_kfunc_check(struct bpf_verifier_env *env,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +/bpf_dev_bound_kfunc_check +2084 kernel/bpf/verifier.c

  2083	
> 2084	int bpf_dev_bound_kfunc_check(struct bpf_verifier_env *env,
  2085				      struct bpf_prog_aux *prog_aux)
  2086	{
  2087		if (!bpf_prog_is_dev_bound(prog_aux)) {
  2088			verbose(env, "metadata kfuncs require device-bound program\n");
  2089			return -EINVAL;
  2090		}
  2091	
  2092		if (bpf_prog_is_offloaded(prog_aux)) {
  2093			verbose(env, "metadata kfuncs can't be offloaded\n");
  2094			return -EINVAL;
  2095		}
  2096	
  2097		return 0;
  2098	}
  2099	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp