Subject: Re: [PATCH v3 2/3] net: dsa: mv88e6xxx: add support for MV88E6020 switch

From: Lukasz Majewski <[email-masked]>
Date: Tue, 3 Jan 2023 09:46:33 +0100

Hi Andrew,

> On Mon, Jan 02, 2023 at 04:02:08PM +0100, Lukasz Majewski wrote:
> > From: Matthias Schiffer <[email-masked]>
> > 
> > A mv88e6250 family (i.e. LinkStreet) switch with 2 PHY and RMII
> > ports and no PTP support.  
> 
> >  static const struct mv88e6xxx_info mv88e6xxx_table[] = {
> > +	[MV88E6020] = {
> > +		.prod_num = MV88E6XXX_PORT_SWITCH_ID_PROD_6020,
> > +		.family = MV88E6XXX_FAMILY_6250,
> > +		.name = "Marvell 88E6020",
> > +		.num_databases = 64,
> > +		.num_ports = 7,
> > +		.num_internal_phys = 5,  
> 
> You say in the commit message there are two PHYs, yet you have 5 here?
> 

It looks like mine copy-paste error.

In the documentation there is stated that the 88E6020 device contains
two 10BASE-T/100BASE-TX transceivers (PHYs) and four independent Fast
Ethernet MACs (so it is a 2+2 device).

The 88E6071 is 5+2 device, so I'm going to correct this value to 2.
Also num_ports needs to be updated to 4.

>     Andrew

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: [email-masked]