Subject: Re: [PATCH net-next 7/9] devlink: allow registering parameters after the instance

From: Jakub Kicinski <[email-masked]>
Date: Fri, 6 Jan 2023 13:22:51 -0800

On Fri, 6 Jan 2023 13:55:53 +0100 Jiri Pirko wrote:
> >@@ -5263,7 +5263,13 @@ static void devlink_param_notify(struct devlink *devlink,
> > 	WARN_ON(cmd != DEVLINK_CMD_PARAM_NEW && cmd != DEVLINK_CMD_PARAM_DEL &&
> > 		cmd != DEVLINK_CMD_PORT_PARAM_NEW &&
> > 		cmd != DEVLINK_CMD_PORT_PARAM_DEL);
> >-	ASSERT_DEVLINK_REGISTERED(devlink);
> >+
> >+	/* devlink_notify_register() / devlink_notify_unregister()
> >+	 * will replay the notifications if the params are added/removed
> >+	 * outside of the lifetime of the instance.
> >+	 */
> >+	if (!devl_is_registered(devlink))
> >+		return;  
> 
> This helper would be nice to use on other places as well.
> Like devlink_trap_group_notify(), devlink_trap_notify() and others. I
> will take care of that in a follow-up.

Alternatively we could reorder back to registering sub-objects
after the instance and not have to worry about re-sending 
notifications :S