Subject: Re: [PATCH ethtool-next v5 2/2] netlink: add netlink handler for get rss (-x)

From: Jakub Kicinski <[email-masked]>
Date: Tue, 10 Jan 2023 17:54:30 -0800

LGTM! Couple of nit picks

On Mon,  9 Jan 2023 20:52:45 -0800 Sudheer Mogilappagari wrote:
> +	if (hfunc) {
> +		for (i = 0; i < get_count(hash_funcs); i++) {
> +			if (hfunc & (1 << i))
> +				print_string(PRINT_JSON, "rss-hash-function",
> +					     NULL, get_string(hash_funcs, i));

break?

> +		}
> +	}

> +	ret = nlsock_process_reply(nlctx->ethnl2_socket, get_channels_cb, args);
> +
> +	if (ret < 0)
> +		return MNL_CB_ERROR;

no empty lines between function call and the error check