Subject: Re: [PATCH v5 net-next 4/5] net: wwan: t7xx: Enable devlink based fw flashing and coredump collection

From: Jakub Kicinski <[email-masked]>
Date: Tue, 24 Jan 2023 20:53:56 -0800

On Sat, 21 Jan 2023 19:03:38 +0530 [email-masked] wrote:
> 1> Driver Registers with Devlink framework.
> 2> Implements devlink ops flash_update callback that programs modem fw.
> 3> Creates region & snapshot required for device coredump log collection.  

Sounds like these should be 3 patches?

> +	devlink_params_register(dl_ctx, t7xx_devlink_params, ARRAY_SIZE(t7xx_devlink_params));
> +	value.vbool = false;
> +	devlink_param_driverinit_value_set(dl_ctx, T7XX_DEVLINK_PARAM_ID_FASTBOOT, value);
> +	devlink_set_features(dl_ctx, DEVLINK_F_RELOAD);
> +	devlink_register(dl_ctx);

Please take the devl_lock() explicitly and use the devl_
version of those calls.