From: "Marek Behún" <kabel@kernel•org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas•com>
Cc: "Russell King (Oracle)" <linux@armlinux•org.uk>,
"andrew@lunn•ch" <andrew@lunn•ch>,
"hkallweit1@gmail•com" <hkallweit1@gmail•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"edumazet@google•com" <edumazet@google•com>,
"kuba@kernel•org" <kuba@kernel•org>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-renesas-soc@vger•kernel.org"
<linux-renesas-soc@vger•kernel.org>
Subject: Re: [PATCH net-next v4 4/4] net: ethernet: renesas: rswitch: Add phy_power_{on,off}() calling
Date: Mon, 30 Jan 2023 17:59:05 +0100 [thread overview]
Message-ID: <20230130175905.7d77781d@thinkpad> (raw)
In-Reply-To: <Y9f0wm1sV6B1/ymC@shell.armlinux.org.uk>
On Mon, 30 Jan 2023 16:48:02 +0000
"Russell King (Oracle)" <linux@armlinux•org.uk> wrote:
> On Mon, Jan 30, 2023 at 05:30:48PM +0100, Marek Behún wrote:
> > But rswitch already uses phylink, so should Yoshihiro convert it whole
> > back to phylib? (I am not sure how much phylink API is used, maybe it
> > can stay that way and the new phylib function as proposed in Yoshihiro's
> > previous proposal can just be added.)
>
> In terms of "how much phylink API is used"... well, all the phylink
> ops functions are currently entirely empty. So, phylink in this case
> is just being nothing more than a shim between the driver and the
> corresponding phylib functions.
>
Yoshihiro, sorry for this. If not for my complaints, your proposal could
already be merged (maybe). Anyway, I think the best solution would be
to implement phylink properly, even for cases that are not relevant for
your board*, but this would take a non-trivial amount of time, so
I will understand if you want to stick with phylib.
* Altough you don't use fixed-link or SFP on your board, I think it
should be possible to test it somehow if you implemented it...
For example, I have tested fixed-link between SOC and switch SerDes
by configuring it in device-tree on both sides.
Marek
next prev parent reply other threads:[~2023-01-30 16:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 14:26 [PATCH net-next v4 0/4] net: ethernet: renesas: rswitch: Modify initialization for SERDES and PHY Yoshihiro Shimoda
2023-01-27 14:26 ` [PATCH net-next v4 1/4] net: phylink: Set host_interfaces for a non-sfp PHY Yoshihiro Shimoda
2023-01-27 14:26 ` [PATCH net-next v4 2/4] net: ethernet: renesas: rswitch: Simplify struct phy * handling Yoshihiro Shimoda
2023-01-27 14:26 ` [PATCH net-next v4 3/4] net: ethernet: renesas: rswitch: Enable ovr_host_interfaces Yoshihiro Shimoda
2023-01-27 14:26 ` [PATCH net-next v4 4/4] net: ethernet: renesas: rswitch: Add phy_power_{on,off}() calling Yoshihiro Shimoda
2023-01-27 15:17 ` Russell King (Oracle)
2023-01-30 5:52 ` Yoshihiro Shimoda
2023-01-30 12:15 ` Russell King (Oracle)
2023-01-30 16:30 ` Marek Behún
2023-01-30 16:48 ` Russell King (Oracle)
2023-01-30 16:59 ` Marek Behún [this message]
2023-01-31 4:42 ` Yoshihiro Shimoda
2023-01-31 4:42 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130175905.7d77781d@thinkpad \
--to=kabel@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-renesas-soc@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=yoshihiro.shimoda.uh@renesas$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox