From: Christoph Hellwig <hch@lst•de>
To: Bart Van Assche <bvanassche@acm•org>
Cc: Christoph Hellwig <hch@lst•de>, Jens Axboe <axboe@kernel•dk>,
Ilya Dryomov <idryomov@gmail•com>,
"Michael S. Tsirkin" <mst@redhat•com>,
Jason Wang <jasowang@redhat•com>,
Minchan Kim <minchan@kernel•org>,
Sergey Senozhatsky <senozhatsky@chromium•org>,
Keith Busch <kbusch@kernel•org>, Sagi Grimberg <sagi@grimberg•me>,
Chaitanya Kulkarni <kch@nvidia•com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
David Howells <dhowells@redhat•com>,
Marc Dionne <marc.dionne@auristor•com>,
Xiubo Li <xiubli@redhat•com>, Steve French <sfrench@samba•org>,
Trond Myklebust <trond.myklebust@hammerspace•com>,
Anna Schumaker <anna@kernel•org>,
Mike Marshall <hubcap@omnibond•com>,
Andrew Morton <akpm@linux-foundation•org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Chuck Lever <chuck.lever@oracle•com>,
linux-block@vger•kernel.org, ceph-devel@vger•kernel.org,
virtualization@lists•linux-foundation.org,
linux-nvme@lists•infradead.org, linux-scsi@vger•kernel.org,
target-devel@vger•kernel.org, kvm@vger•kernel.org,
netdev@vger•kernel.org, linux-afs@lists•infradead.org,
linux-cifs@vger•kernel.org, samba-technical@lists•samba.org,
linux-fsdevel@vger•kernel.org, linux-nfs@vger•kernel.org,
devel@lists•orangefs.org, io-uring@vger•kernel.org,
linux-mm@kvack•org
Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper
Date: Tue, 31 Jan 2023 14:45:21 +0100 [thread overview]
Message-ID: <20230131134521.GA24165@lst.de> (raw)
In-Reply-To: <2bab7050-dec7-3af8-b643-31b414b8c4b4@acm.org>
On Mon, Jan 30, 2023 at 09:09:23AM -0800, Bart Van Assche wrote:
> Has it been considered to use structure assignment instead of introducing
> bvec_set_page(), e.g. as follows?
>
> bip->bip_vec[bip->bip_vcnt] = (struct bio_vec) {
> .bv_page = page, .bv_len = len, .bv_offset = offset };
Unless it's hidden behind a macro it doesn't solve the problem of
abstraction away the layout. I'm also find it less readable.
next prev parent reply other threads:[~2023-01-31 13:45 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 9:21 add bvec initialization helpers Christoph Hellwig
2023-01-30 9:21 ` [PATCH 01/23] block: factor out a bvec_set_page helper Christoph Hellwig
2023-01-30 10:33 ` David Howells
2023-01-30 10:36 ` Christoph Hellwig
2023-01-30 18:35 ` Ilya Dryomov
2023-01-30 11:55 ` Johannes Thumshirn
2023-01-30 17:09 ` Bart Van Assche
2023-01-30 19:24 ` Bart Van Assche
2023-01-31 13:45 ` Christoph Hellwig [this message]
2023-01-31 4:47 ` Jakub Kicinski
2023-01-31 5:00 ` Matthew Wilcox
2023-01-31 5:28 ` Matthew Wilcox
2023-01-31 5:52 ` Jakub Kicinski
2023-01-31 6:55 ` Chaitanya Kulkarni
2023-01-30 9:21 ` [PATCH 02/23] block: add a bvec_set_folio helper Christoph Hellwig
2023-01-30 11:54 ` Johannes Thumshirn
2023-01-31 6:55 ` Chaitanya Kulkarni
2023-01-30 9:21 ` [PATCH 03/23] block: add a bvec_set_virt helper Christoph Hellwig
2023-01-30 12:08 ` Johannes Thumshirn
2023-01-31 6:55 ` Chaitanya Kulkarni
2023-01-30 9:21 ` [PATCH 04/23] sd: factor out a sd_set_special_bvec helper Christoph Hellwig
2023-01-31 6:56 ` Chaitanya Kulkarni
2023-01-30 9:21 ` [PATCH 05/23] target: use bvec_set_page to initialize bvecs Christoph Hellwig
2023-01-31 6:56 ` Chaitanya Kulkarni
2023-01-30 9:21 ` [PATCH 06/23] nvmet: " Christoph Hellwig
2023-01-30 12:07 ` Johannes Thumshirn
2023-01-31 6:57 ` Chaitanya Kulkarni
2023-01-30 9:21 ` [PATCH 07/23] nvme: use bvec_set_virt to initialize special_vec Christoph Hellwig
2023-01-30 12:09 ` Johannes Thumshirn
2023-01-31 6:58 ` Chaitanya Kulkarni
2023-01-30 9:21 ` [PATCH 08/23] rbd: use bvec_set_page to initialize the copy up bvec Christoph Hellwig
2023-01-30 17:47 ` Ilya Dryomov
2023-01-30 9:21 ` [PATCH 09/23] virtio_blk: use bvec_set_virt to initialize special_vec Christoph Hellwig
2023-01-30 15:17 ` Michael S. Tsirkin
2023-01-31 3:22 ` Jason Wang
2023-01-31 6:57 ` Chaitanya Kulkarni
2023-01-30 9:21 ` [PATCH 10/23] zram: use bvec_set_page to initialize bvecs Christoph Hellwig
2023-01-30 13:31 ` Johannes Thumshirn
2023-01-31 2:34 ` Sergey Senozhatsky
2023-01-30 9:21 ` [PATCH 11/23] afs: use bvec_set_folio to initialize a bvec Christoph Hellwig
2023-01-30 15:59 ` David Howells
2023-01-30 9:21 ` [PATCH 12/23] ceph: use bvec_set_page " Christoph Hellwig
2023-01-30 18:02 ` Ilya Dryomov
2023-01-31 1:51 ` Xiubo Li
2023-01-30 9:21 ` [PATCH 13/23] cifs: use bvec_set_page to initialize bvecs Christoph Hellwig
2023-01-30 15:56 ` Paulo Alcantara
2023-01-30 9:21 ` [PATCH 14/23] coredump: use bvec_set_page to initialize a bvec Christoph Hellwig
2023-01-30 9:21 ` [PATCH 15/23] nfs: use bvec_set_page to initialize bvecs Christoph Hellwig
2023-01-30 9:21 ` [PATCH 16/23] orangefs: use bvec_set_{page,folio} " Christoph Hellwig
2023-01-30 9:21 ` [PATCH 17/23] splice: use bvec_set_page to initialize a bvec Christoph Hellwig
2023-01-30 9:21 ` [PATCH 18/23] io_uring: " Christoph Hellwig
2023-01-31 6:59 ` Chaitanya Kulkarni
2023-01-30 9:21 ` [PATCH 19/23] swap: use bvec_set_page to initialize bvecs Christoph Hellwig
2023-01-30 9:21 ` [PATCH 20/23] rxrpc: use bvec_set_page to initialize a bvec Christoph Hellwig
2023-01-30 10:31 ` David Howells
2023-01-30 10:33 ` Christoph Hellwig
2023-01-30 11:24 ` David Howells
2023-01-30 12:18 ` Christoph Hellwig
2023-01-30 15:58 ` David Howells
2023-01-30 9:21 ` [PATCH 21/23] sunrpc: use bvec_set_page to initialize bvecs Christoph Hellwig
2023-01-30 15:38 ` Chuck Lever III
2023-01-30 9:21 ` [PATCH 22/23] vring: use bvec_set_page to initialize a bvec Christoph Hellwig
2023-01-30 15:19 ` Michael S. Tsirkin
2023-01-31 2:31 ` Jason Wang
2023-01-30 9:21 ` [PATCH 23/23] net-ceph: use bvec_set_page to initialize bvecs Christoph Hellwig
2023-01-30 18:20 ` Ilya Dryomov
-- strict thread matches above, loose matches on Subject: below --
2023-02-03 15:06 add bvec initialization helpers v2 Christoph Hellwig
2023-02-03 15:06 ` [PATCH 01/23] block: factor out a bvec_set_page helper Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131134521.GA24165@lst.de \
--to=hch@lst$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anna@kernel$(echo .)org \
--cc=axboe@kernel$(echo .)dk \
--cc=bvanassche@acm$(echo .)org \
--cc=ceph-devel@vger$(echo .)kernel.org \
--cc=chuck.lever@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devel@lists$(echo .)orangefs.org \
--cc=dhowells@redhat$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=hubcap@omnibond$(echo .)com \
--cc=idryomov@gmail$(echo .)com \
--cc=io-uring@vger$(echo .)kernel.org \
--cc=jasowang@redhat$(echo .)com \
--cc=kbusch@kernel$(echo .)org \
--cc=kch@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-afs@lists$(echo .)infradead.org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-cifs@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=linux-nvme@lists$(echo .)infradead.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=marc.dionne@auristor$(echo .)com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=minchan@kernel$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sagi@grimberg$(echo .)me \
--cc=samba-technical@lists$(echo .)samba.org \
--cc=senozhatsky@chromium$(echo .)org \
--cc=sfrench@samba$(echo .)org \
--cc=target-devel@vger$(echo .)kernel.org \
--cc=trond.myklebust@hammerspace$(echo .)com \
--cc=virtualization@lists$(echo .)linux-foundation.org \
--cc=xiubli@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox